Only add branding to onwards content cards for labs content#15178
Only add branding to onwards content cards for labs content#15178
Conversation
cemms1
added
fix
github-actions
Bot
removed
the
run_chromatic
| {!!branding && isOnwardContent && ( | ||
| <LabsBranding /> | ||
| )} | ||
| {!!branding && |
There was a problem hiding this comment.
Checking the logic of nesting in showPill FMI — is this (edit: the branding) something we only ever want to show for isMediaCardOrNewsletter && !isGallerySecondaryOnward?
There was a problem hiding this comment.
The pill should only show on media / newsletter cards (representing Video/Gallery/Audio/Newsletter articles) in general.
The isGallerySecondardaryOnward represents a "secondary" level onward content component on gallery articles. This came in recently due to an upcoming redesign for gallery onwards content (started by WebEx and continued by F&C). See comment here #14894 (comment)
So apparently we explicitly don't want to show a media pill on the "related stories" onward content
There was a problem hiding this comment.
The logic in this component is super hard to follow and seems to be getting worse. I'll start a conversation thread somewhere for this!
2 participants
What does this change?
Restricts the branding on onwards content to only appear for labs content
Why?
A bug was introduced on #15039 where the Guardian Org logo was showing on an onwards media card, which looks odd amongst other cards with branding
The branding should only apply for Labs content
Screenshots