Skip to content

[StandardLinkElementButton]: Correct display logic for external links#15180

Merged
jonathonherbert merged 1 commit intomainfrom
jsh/add-standard-button
Jan 22, 2026
Merged

[StandardLinkElementButton]: Correct display logic for external links#15180
jonathonherbert merged 1 commit intomainfrom
jsh/add-standard-button

Conversation

@jonathonherbert
Copy link
Copy Markdown
Contributor

What does this change?

Reverses the logic for the external links in StandardLinkElementButton.

Why?

'Cos they're the wrong way round 😅

Screenshots

Before After
Screenshot 2026-01-21 at 21 49 52 Screenshot 2026-01-21 at 21 50 41

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 21, 2026

@github-actions
Copy link
Copy Markdown

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@jonathonherbert jonathonherbert self-assigned this Jan 21, 2026
@jonathonherbert jonathonherbert added maintenance Departmental tracking: maintenance work, not a fix or a feature feature Departmental tracking: work on a new feature and removed maintenance Departmental tracking: maintenance work, not a fix or a feature labels Jan 21, 2026
@jonathonherbert jonathonherbert added this to the Visuals milestone Jan 21, 2026
@jonathonherbert jonathonherbert force-pushed the jsh/add-standard-button branch from 569beef to 2ef14aa Compare January 21, 2026 21:55
@jonathonherbert jonathonherbert added the run_chromatic Runs chromatic when label is applied label Jan 21, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Jan 21, 2026
Copy link
Copy Markdown
Contributor

@groakland groakland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@simonbyford simonbyford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!

@jonathonherbert jonathonherbert merged commit d1d9de8 into main Jan 22, 2026
52 checks passed
@jonathonherbert jonathonherbert deleted the jsh/add-standard-button branch January 22, 2026 10:24
@gu-prout
Copy link
Copy Markdown

gu-prout Bot commented Jan 22, 2026

Seen on PROD (merged by @jonathonherbert 7 minutes and 55 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Departmental tracking: work on a new feature Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants