Remove tap highlight colour from video#15666
Conversation
|
Seen on PROD (merged by @domlander 17 minutes and 45 seconds ago) Please check your changes! |
abeddow91
left a comment
There was a problem hiding this comment.
I agree that it looks more polished but as its webkit, the browser support looks to be quite low (https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/-webkit-tap-highlight-color) and would only support webkit (eg not firefox for example) which means different behaviours across browsers and devices (eg supported on chrome but not safari desktop)
Equally, are there any accessibility concerns by removing this flash?
| css={[ | ||
| videoStyles(aspectRatio, isCinemagraph), | ||
| videoStyles(aspectRatio), | ||
| isCinemagraph && cinemagraphStyles, |
There was a problem hiding this comment.
Pleased to see the refactor towards composable styles, personally i find this much easier to parse and it better seperates concerns.
This change ensures that the functionality on the supported browsers listed there matches the functionality of the other browsers. The blue flash is not seen on browsers that do not support this property, so this change makes the experience consistent across browsers.
I don't think so, since the effect is purely visual and there is naturally a visual cue to indicate that the video has been tapped: the video is played and the play icon removed, or the video is paused and the play icon is displayed. |
What does this change?
Removes the tap highlight colour from videos. Affects some browsers on mobile devices.
Why?
This will stop the flash of blue when tapping a video to play/pause
Screenshots
Before
before.mov
After
after.mov