Skip to content

Remove tap highlight colour from video#15666

Merged
domlander merged 1 commit intomainfrom
doml/remove-phone-focus-video
Apr 8, 2026
Merged

Remove tap highlight colour from video#15666
domlander merged 1 commit intomainfrom
doml/remove-phone-focus-video

Conversation

@domlander
Copy link
Copy Markdown
Contributor

@domlander domlander commented Apr 8, 2026

What does this change?

Removes the tap highlight colour from videos. Affects some browsers on mobile devices.

Why?

This will stop the flash of blue when tapping a video to play/pause

Screenshots

Before

before.mov

After

after.mov

@domlander domlander self-assigned this Apr 8, 2026
@domlander domlander added run_chromatic Runs chromatic when label is applied fronts + curation maintenance Departmental tracking: maintenance work, not a fix or a feature labels Apr 8, 2026
@domlander domlander marked this pull request as ready for review April 8, 2026 09:18
@domlander domlander requested a review from abeddow91 April 8, 2026 09:18
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Apr 8, 2026
@domlander domlander merged commit dbab361 into main Apr 8, 2026
37 checks passed
@domlander domlander deleted the doml/remove-phone-focus-video branch April 8, 2026 10:36
@gu-prout
Copy link
Copy Markdown

gu-prout Bot commented Apr 8, 2026

Seen on PROD (merged by @domlander 17 minutes and 45 seconds ago) Please check your changes!

Copy link
Copy Markdown
Contributor

@abeddow91 abeddow91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it looks more polished but as its webkit, the browser support looks to be quite low (https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/-webkit-tap-highlight-color) and would only support webkit (eg not firefox for example) which means different behaviours across browsers and devices (eg supported on chrome but not safari desktop)

Equally, are there any accessibility concerns by removing this flash?

css={[
videoStyles(aspectRatio, isCinemagraph),
videoStyles(aspectRatio),
isCinemagraph && cinemagraphStyles,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pleased to see the refactor towards composable styles, personally i find this much easier to parse and it better seperates concerns.

@domlander
Copy link
Copy Markdown
Contributor Author

I agree that it looks more polished but as its webkit, the browser support looks to be quite low (https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/-webkit-tap-highlight-color) and would only support webkit (eg not firefox for example) which means different behaviours across browsers and devices (eg supported on chrome but not safari desktop)

This change ensures that the functionality on the supported browsers listed there matches the functionality of the other browsers. The blue flash is not seen on browsers that do not support this property, so this change makes the experience consistent across browsers.

Equally, are there any accessibility concerns by removing this flash?

I don't think so, since the effect is purely visual and there is naturally a visual cue to indicate that the video has been tapped: the video is played and the play icon removed, or the video is paused and the play icon is displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fronts + curation maintenance Departmental tracking: maintenance work, not a fix or a feature Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants