Only send optimised sources to video component#15670
Merged
Conversation
domlander
added
run_chromatic
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
abeddow91
approved these changes
Apr 8, 2026
Georges-GNM
approved these changes
Apr 8, 2026
|
Seen on PROD (merged by @domlander 9 minutes and 16 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Sets the initial value of
optimisedSourcesto an empty array.Sources are filtered before they are available to the video component.
Why?
The video element initially receives all video sources. Before the javascript loads and the sources are filtered, the browser may start to download a source that is not preferred for their browser. For example, a user on a small mobile device may find that there browser starts downloading the
_720hsource, before the JS runs to remove this source.Once a video has decided on a source from its list, it may not update to another source, even if this original source is removed via JS.