Conversation
domlander
added
run_chromatic
domlander
force-pushed
the
doml/sh-default
branch
2 times, most recently
from
ebc9288 to
9205bd4
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
abeddow91
reviewed
Apr 9, 2026
abeddow91
reviewed
Apr 9, 2026
abeddow91
reviewed
Apr 13, 2026
| ) { | ||
| setCurrentTime(ref.current.currentTime); | ||
| if (currentRefExists && playerState === 'PLAYING') { | ||
| setCurrentTime(ref.current!.currentTime); |
Contributor
There was a problem hiding this comment.
Nice! I didn't know you can force the compiler to remove null and undefined from the type using !
abeddow91
approved these changes
Apr 13, 2026
domlander
force-pushed
the
doml/sh-default
branch
from
825125e to
467bba6
Compare
github-actions
Bot
removed
the
run_chromatic
domlander
force-pushed
the
doml/sh-default
branch
from
467bba6 to
da9d6c4
Compare
github-actions
Bot
removed
the
run_chromatic
|
Seen on PROD (merged by @domlander 8 minutes and 45 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds support for the "Default" video style of self-hosted. This style is known as "non-youtube" in the tools.
Default video:
preload=metadatacan be costly as a portion of the video is downloaded alongside the metadata. There is no way to only download the video metadata using thepreloadattribute. If we find that default videos are usually played or the wait between clicking play and the video playing is too long, then we will revisit this. This is also tied to autoplay: if we autoplay, we will preload data.ShowControlsis split out: we may want to display the play icon even if the video is not currently playable (we haven't preloaded data).Removes
videoStylelogic from the player component. Let's keep the logic within the island component as much as we can, so that the player can be "dumb".Updates feature card self-hosted video stories to use the videos in fixtures.
Note: Designs will be updated in a future PR.
Why?
So that we can start using longer videos. We don't necessarily want to loop or autoplay longer videos.
Screenshots
Immersive feature card
shows no autoplay and icons appear on playback
Screen.Recording.2026-04-09.at.12.15.24.mov
Card
Also demonstrates shows button functionality and no loop
Screen.Recording.2026-04-09.at.12.18.31.mov