Remove small option for YouTube video play icon#15681
Merged
Conversation
domlander
added
run_chromatic
domlander
force-pushed
the
doml/refactor-youtube-play-icon
branch
from
33ddc6a to
fb5947a
Compare
domlander
force-pushed
the
doml/refactor-youtube-play-icon
branch
from
fb5947a to
ec89ac4
Compare
domlander
changed the title
abeddow91
approved these changes
Apr 13, 2026
|
Seen on PROD (merged by @domlander 25 minutes and 47 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Removes the
smalloption for the play icon in Youtube cards.Also, updates Youtube card stories to make them more similar to how they might be used. For example, a card that displays its content horizontally on mobile with the media taking up a third of the space would not play Youtube video.
Why?
It is not possible in existing containers (since the Front redesign Jan 2025) to have a situation where we'd use the small play icon for Youtube. In situations where the video is really small, we do not allow the video to be played.
An 72px play icon does feel on the large side on mobile screens, but this is existing functionality. This PR does not attempt to change this. Icon sizing for Youtube cards may be revisited in the upcoming work on self-hosted video play icons, as it would be good to have consistency.