Add notifications to football match header#15720
Merged
Conversation
The header now takes a `NotificationsClient` as a prop. The live version of this is passed from the wrapper component, and a mock version is passed in the stories. There are also some small changes to the stories to ensure that a mix of apps and web versions of the header are captured, demonstrating that notifications are correctly shown on apps and not on web. For the notification payload sent via Bridget a "display name" is required, which specifies the two teams and the date of the match. This change therefore includes a function to calculate this from the match information, and some tests to ensure this works as expected.
github-actions
Bot
removed
the
run_chromatic
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
|
Seen on PROD (merged by @JamieB-gu 10 minutes and 11 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header now takes a
NotificationsClientas a prop. The live version of this is passed from the wrapper component, and a mock version is passed in the stories. There are also some small changes to the stories to ensure that a mix of apps and web versions of the header are captured, demonstrating that notifications are correctly shown on apps and not on web.For the notification payload sent via Bridget a "display name" is required, which specifies the two teams and the date of the match. This change therefore includes a function to calculate this from the match information, and some tests to ensure this works as expected.
Part of #14905.