Skip to content

Fix ESLint hoisting in .npmrc#15723

Merged
DanielCliftonGuardian merged 4 commits intomainfrom
es-lint-import-fix
Apr 17, 2026
Merged

Fix ESLint hoisting in .npmrc#15723
DanielCliftonGuardian merged 4 commits intomainfrom
es-lint-import-fix

Conversation

@DanielCliftonGuardian
Copy link
Copy Markdown
Contributor

@DanielCliftonGuardian DanielCliftonGuardian commented Apr 17, 2026

What does this change?

Adds public-hoist-pattern[]=*eslint* to .npmrc to restore hoisting of ESLint packages to the root node_modules following upgrade of pnpm. See workflows for a-b testing failing since merge
Also adds confirmModulesPurge=false to .npmrc to allow pnpm to automatically purge and recreate node_modules in CI and pre-push hooks.

See relevant issue pnpm/pnpm#8378

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 17, 2026

@DanielCliftonGuardian DanielCliftonGuardian changed the title Update eslint.config.mjs Fix ESLint hoisting in .npmrc Apr 17, 2026
@DanielCliftonGuardian DanielCliftonGuardian changed the title Fix ESLint hoisting in .npmrc Fix ESLint hoisting in .npmrc Apr 17, 2026
@DanielCliftonGuardian DanielCliftonGuardian marked this pull request as ready for review April 17, 2026 11:04
@DanielCliftonGuardian DanielCliftonGuardian requested a review from a team as a code owner April 17, 2026 11:04
@github-actions
Copy link
Copy Markdown

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@DanielCliftonGuardian DanielCliftonGuardian self-assigned this Apr 17, 2026
@DanielCliftonGuardian DanielCliftonGuardian added the fix Departmental tracking: fix label Apr 17, 2026
@DanielCliftonGuardian DanielCliftonGuardian added this to the Health milestone Apr 17, 2026
@DanielCliftonGuardian DanielCliftonGuardian added the run_chromatic Runs chromatic when label is applied label Apr 17, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Apr 17, 2026
@DanielCliftonGuardian DanielCliftonGuardian added the run_chromatic Runs chromatic when label is applied label Apr 17, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Apr 17, 2026
@DanielCliftonGuardian DanielCliftonGuardian merged commit 1211014 into main Apr 17, 2026
27 checks passed
@DanielCliftonGuardian DanielCliftonGuardian deleted the es-lint-import-fix branch April 17, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Departmental tracking: fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants