Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
SHession
left a comment
There was a problem hiding this comment.
Changes make sense, I have tested interactions with the player locally. One small functional change, but otherwise LGTM
|
|
||
| const seekBackward = () => { | ||
| if (vidRef.current) { | ||
| // Allow the user to cycle to the end of the video using the arrow keys |
There was a problem hiding this comment.
Small change of behaviour here, although it doesn't seem necessarily worth keeping.
There was a problem hiding this comment.
Ah yes, I did explain the reasoning behind this in the PR to implement a new progress bar, but I forgot to move the comment over when I split this PR out: #15726 (comment)
In short, It's an very minor feature that increase the complexity of the code quite a bit when non-looping (default) video is added, so this is why it's removed.
|
Seen on PROD (merged by @domlander 8 minutes and 15 seconds ago) Please check your changes! |
What does this change?
This is a no-op change.
onTimeUpdateevent fires on the video is moved up to the island component.Why?
How to test?
Run storybook locally. Locate the SelfHostedVideo stories