Update eslint, @guardian/eslint-config and switch to flat config#15864
Merged
Conversation
Jakeii
added
the
maintenance
This was
linked to
issues
May 14, 2026
Closed
Closed
Jakeii
changed the title
Jakeii
changed the title
Jakeii
commented
May 14, 2026
| webpackFinal: async (config) => { | ||
| // Get project specific webpack options | ||
| config = webpackConfig(config); | ||
| const newConfig = webpackConfig(config); |
Member
Author
There was a problem hiding this comment.
to silence eslint/no-param-reassign
Jakeii
commented
May 14, 2026
| }, | ||
| { | ||
| filepath: 'package.json', | ||
| pattern: /^\t+"@types\/node"\: "(.+)",$/m, |
Jakeii
commented
May 14, 2026
| files: ['**/**.tsx'], | ||
| rules: { | ||
| '@typescript-eslint/no-restricted-types': [ | ||
| 'warn', |
Member
Author
There was a problem hiding this comment.
this warn version of @typescript-eslint/no-restricted-types was being overridden by the error one below, I've just removed it as there isn't a way to have separate warn and error types for this rule, and there' still quite a lot of use of JSX.Element
github-actions
Bot
removed
the
run_chromatic
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
@guardian/eslint-config-typescriptto@guardian/eslint-configeslintto version 9 (@guardian/eslint-configis not on 10 yet)Some new rules have been introduced to the recommended configs for typescript-eslint and react-hooks, I've set them to warn (from default error) for now.
Some other rules have been renamed/replaced.
The flat config now requires plugins to be direct dependencies (they were previously picked up as transients of @guardian/eslint-config-typescript`)
A new formatting rule has been introduced forcing single line if statements without a block to use a block, which has increased the surface area of this PR a bit.
Other code changes from autofix or manual updating include, use of
Recordtype and removing/addingeslint-disablewhere needed.dropped
eslint-plugin-jsx-expressionsit doesn't work with eslint 9 and it's rules are covered by others now I believe.Why?
Keep up to date with eslint, this also helps unblock upgrading typescript.