Add new cricket scorecard page#15882
Open
Jakeii wants to merge 2 commits into
Open
Conversation
Jakeii
added
feature
github-actions
Bot
removed
the
run_chromatic
Jakeii
force-pushed
the
jlk/new-cricket-scorecard-page-2
branch
from
7e2333a to
c2b332b
Compare
github-actions
Bot
removed
the
run_chromatic
arelra
approved these changes
May 18, 2026
| parameters: { | ||
| chromatic: { | ||
| modes: { | ||
| 'light leftCol': allModes['light leftCol'], |
Member
There was a problem hiding this comment.
Will this page be used in apps? In which case we should apply dark mode styles?
Member
Author
There was a problem hiding this comment.
Yep it is, fortunately it looks in dark mode mostly as is, although I did find there's a ticket to tweak the scorecard a little
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Combine the new cricket header and scorecard component into the new scorecard page component.
Why?
New pretty score card page
Screenshots