Merged
Conversation
|
Size Change: +6 B (0%) Total Size: 701 kB ℹ️ View Unchanged
|
2f3a605 to
c510432
Compare
mxdvl
approved these changes
Nov 21, 2023
Member
Author
Also in the PR description: The |
Contributor
Should we fix it upstream? |
Member
Author
Good point will do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Replace all
data-cyattributes as we are migrating to Playwright as suggested by @georgeblahblah here .I opted to replace it with with the more generic
data-testidwhich is a convention used by react-testing-library.Ideally we should move away from using specific test ids and assert on behaviour that the user would see.
The
epic.interactivity.cy.jsLiveBlogEpictest still asserts ondata-cyas it looks like its rendered output it not coming from DCR.