Replace `data-cy` with `data-testid` by arelra · Pull Request #9541 · guardian/dotcom-rendering

arelra · 2023-11-16T17:57:52Z

What does this change?

Replace all data-cy attributes as we are migrating to Playwright as suggested by @georgeblahblah here .

I opted to replace it with with the more generic data-testid which is a convention used by react-testing-library.

Ideally we should move away from using specific test ids and assert on behaviour that the user would see.

The epic.interactivity.cy.js LiveBlogEpic test still asserts on data-cy as it looks like its rendered output it not coming from DCR.

github-actions · 2023-11-16T18:04:21Z

Size Change: +6 B (0%)

Total Size: 701 kB

ℹ️ View Unchanged

Filename	Size	Change
`dotcom-rendering/dist/100.web.********************.js`	990 B	0 B
`dotcom-rendering/dist/1076.web.********************.js`	3.08 kB	0 B
`dotcom-rendering/dist/1136.web.********************.js`	884 B	0 B
`dotcom-rendering/dist/1178.web.********************.js`	504 B	0 B
`dotcom-rendering/dist/1226.web.********************.js`	3.66 kB	0 B
`dotcom-rendering/dist/1294.web.********************.js`	5.36 kB	0 B
`dotcom-rendering/dist/1406.web.********************.js`	5.09 kB	0 B
`dotcom-rendering/dist/1418.web.********************.js`	10.3 kB	-6 B (0%)
`dotcom-rendering/dist/1465.web.********************.js`	3.32 kB	0 B
`dotcom-rendering/dist/1520.web.********************.js`	492 B	0 B
`dotcom-rendering/dist/1521.web.********************.js`	5.48 kB	0 B
`dotcom-rendering/dist/1659.web.********************.js`	518 B	0 B
`dotcom-rendering/dist/1714.web.********************.js`	3.5 kB	0 B
`dotcom-rendering/dist/1959.web.********************.js`	29.5 kB	0 B
`dotcom-rendering/dist/1987.web.********************.js`	3.12 kB	0 B
`dotcom-rendering/dist/2092.web.********************.js`	849 B	0 B
`dotcom-rendering/dist/2096.web.********************.js`	13 kB	0 B
`dotcom-rendering/dist/2133.web.********************.js`	4.46 kB	0 B
`dotcom-rendering/dist/2186.web.********************.js`	916 B	0 B
`dotcom-rendering/dist/2351.web.********************.js`	3.34 kB	0 B
`dotcom-rendering/dist/2394.web.********************.js`	2.66 kB	0 B
`dotcom-rendering/dist/2467.web.********************.js`	2.08 kB	0 B
`dotcom-rendering/dist/2510.web.********************.js`	663 B	0 B
`dotcom-rendering/dist/2511.web.********************.js`	819 B	0 B
`dotcom-rendering/dist/254.web.********************.js`	638 B	0 B
`dotcom-rendering/dist/2546.web.********************.js`	3.72 kB	0 B
`dotcom-rendering/dist/2879.web.********************.js`	910 B	0 B
`dotcom-rendering/dist/2919.web.********************.js`	900 B	0 B
`dotcom-rendering/dist/2923.web.********************.js`	720 B	0 B
`dotcom-rendering/dist/3030.web.********************.js`	957 B	0 B
`dotcom-rendering/dist/3111.web.********************.js`	590 B	0 B
`dotcom-rendering/dist/3146.web.********************.js`	6.53 kB	0 B
`dotcom-rendering/dist/3149.web.********************.js`	636 B	0 B
`dotcom-rendering/dist/3265.web.********************.js`	916 B	0 B
`dotcom-rendering/dist/3302.web.********************.js`	820 B	0 B
`dotcom-rendering/dist/3389.web.********************.js`	884 B	0 B
`dotcom-rendering/dist/3795.web.********************.js`	797 B	0 B
`dotcom-rendering/dist/3968.web.********************.js`	3.79 kB	0 B
`dotcom-rendering/dist/4012.web.********************.js`	783 B	0 B
`dotcom-rendering/dist/4265.web.********************.js`	2.79 kB	0 B
`dotcom-rendering/dist/4306.web.********************.js`	6.46 kB	0 B
`dotcom-rendering/dist/4349.web.********************.js`	775 B	0 B
`dotcom-rendering/dist/4591.web.********************.js`	404 B	0 B
`dotcom-rendering/dist/4593.web.********************.js`	1.74 kB	0 B
`dotcom-rendering/dist/4627.web.********************.js`	783 B	0 B
`dotcom-rendering/dist/4797.web.********************.js`	744 B	0 B
`dotcom-rendering/dist/480.web.********************.js`	524 B	0 B
`dotcom-rendering/dist/489.web.********************.js`	5.22 kB	0 B
`dotcom-rendering/dist/5113.web.********************.js`	2.78 kB	0 B
`dotcom-rendering/dist/5225.web.********************.js`	6.67 kB	0 B
`dotcom-rendering/dist/5332.web.********************.js`	820 B	0 B
`dotcom-rendering/dist/5495.web.********************.js`	676 B	0 B
`dotcom-rendering/dist/5688.web.********************.js`	3.79 kB	0 B
`dotcom-rendering/dist/5744.web.********************.js`	720 B	0 B
`dotcom-rendering/dist/6068.web.********************.js`	775 B	0 B
`dotcom-rendering/dist/6126.web.********************.js`	2.23 kB	0 B
`dotcom-rendering/dist/6295.web.********************.js`	999 B	0 B
`dotcom-rendering/dist/639.web.********************.js`	951 B	0 B
`dotcom-rendering/dist/6428.web.********************.js`	741 B	0 B
`dotcom-rendering/dist/6442.web.********************.js`	2.77 kB	0 B
`dotcom-rendering/dist/657.web.********************.js`	2.46 kB	0 B
`dotcom-rendering/dist/6609.web.********************.js`	872 B	0 B
`dotcom-rendering/dist/6967.web.********************.js`	850 B	0 B
`dotcom-rendering/dist/7569.web.********************.js`	4.94 kB	0 B
`dotcom-rendering/dist/7650.web.********************.js`	23 kB	0 B
`dotcom-rendering/dist/7701.web.********************.js`	647 B	0 B
`dotcom-rendering/dist/8085.web.********************.js`	2.59 kB	0 B
`dotcom-rendering/dist/8112.web.********************.js`	3.37 kB	0 B
`dotcom-rendering/dist/8172.web.********************.js`	2.53 kB	0 B
`dotcom-rendering/dist/818.web.********************.js`	2.85 kB	0 B
`dotcom-rendering/dist/8268.web.********************.js`	5.42 kB	0 B
`dotcom-rendering/dist/8395.web.********************.js`	580 B	0 B
`dotcom-rendering/dist/8401.web.********************.js`	922 B	0 B
`dotcom-rendering/dist/8439.web.********************.js`	4.94 kB	0 B
`dotcom-rendering/dist/9196.web.********************.js`	784 B	0 B
`dotcom-rendering/dist/9251.web.********************.js`	2.22 kB	0 B
`dotcom-rendering/dist/9390.web.********************.js`	743 B	0 B
`dotcom-rendering/dist/9422.web.********************.js`	614 B	0 B
`dotcom-rendering/dist/9581.web.********************.js`	797 B	0 B
`dotcom-rendering/dist/9582.web.********************.js`	710 B	0 B
`dotcom-rendering/dist/9597.web.********************.js`	3.25 kB	0 B
`dotcom-rendering/dist/9617.web.********************.js`	1 kB	0 B
`dotcom-rendering/dist/9724.web.********************.js`	5.02 kB	0 B
`dotcom-rendering/dist/AdPortals-importable.web.********************.js`	4.29 kB	0 B
`dotcom-rendering/dist/AlreadyVisited-importable.web.********************.js`	412 B	0 B
`dotcom-rendering/dist/AppEmailSignUp-importable.web.********************.js`	7.21 kB	0 B
`dotcom-rendering/dist/AppsEpic-importable.web.********************.js`	3.96 kB	0 B
`dotcom-rendering/dist/AppsFooter-importable.web.********************.js`	3.44 kB	0 B
`dotcom-rendering/dist/AppsLightboxImage-importable.web.********************.js`	2.82 kB	0 B
`dotcom-rendering/dist/AudioAtomWrapper-importable.web.********************.js`	3.27 kB	0 B
`dotcom-rendering/dist/AustralianTerritorySwitcher-importable.web.********************.js`	4.86 kB	0 B
`dotcom-rendering/dist/Branding-importable.web.********************.js`	2.46 kB	0 B
`dotcom-rendering/dist/braze-web-sdk-core.web.********************.js`	36.9 kB	0 B
`dotcom-rendering/dist/BrazeMessaging-importable.web.********************.js`	5.55 kB	0 B
`dotcom-rendering/dist/CalloutBlockComponent-importable.web.********************.js`	6.47 kB	0 B
`dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.web.********************.js`	5.76 kB	0 B
`dotcom-rendering/dist/CardCommentCount-importable.web.********************.js`	2.67 kB	0 B
`dotcom-rendering/dist/Carousel-importable.web.********************.js`	7.62 kB	0 B
`dotcom-rendering/dist/CarouselForNewsletters-importable.web.********************.js`	5.6 kB	0 B
`dotcom-rendering/dist/ChartAtom-importable.web.********************.js`	500 B	0 B
`dotcom-rendering/dist/CommentCount-importable.web.********************.js`	2.84 kB	-4 B (0%)
`dotcom-rendering/dist/DiscussionContainer-importable.web.********************.js`	23.9 kB	+2 B (0%)
`dotcom-rendering/dist/DiscussionMeta-importable.web.********************.js`	3.75 kB	0 B
`dotcom-rendering/dist/DocumentBlockComponent-importable.web.********************.js`	3.52 kB	0 B
`dotcom-rendering/dist/EmbedBlockComponent-importable.web.********************.js`	4.06 kB	+3 B (0%)
`dotcom-rendering/dist/EnhancePinnedPost-importable.web.********************.js`	1.95 kB	0 B
`dotcom-rendering/dist/FetchOnwardsData-importable.web.********************.js`	2.5 kB	0 B
`dotcom-rendering/dist/FilterKeyEventsToggle-importable.web.********************.js`	3.31 kB	0 B
`dotcom-rendering/dist/FocusStyles-importable.web.********************.js`	607 B	0 B
`dotcom-rendering/dist/FollowWrapper-importable.web.********************.js`	3.9 kB	0 B
`dotcom-rendering/dist/FooterLabel-importable.web.********************.js`	336 B	0 B
`dotcom-rendering/dist/frameworks.web.********************.js`	20.8 kB	0 B
`dotcom-rendering/dist/GetCricketScoreboard-importable.web.********************.js`	3.26 kB	0 B
`dotcom-rendering/dist/GetMatchNav-importable.web.********************.js`	12.5 kB	0 B
`dotcom-rendering/dist/GetMatchStats-importable.web.********************.js`	355 B	0 B
`dotcom-rendering/dist/GetMatchTabs-importable.web.********************.js`	2.31 kB	0 B
`dotcom-rendering/dist/guardian-braze-components-banner.web.********************.js`	13.4 kB	0 B
`dotcom-rendering/dist/guardian-braze-components-end-of-article.web.********************.js`	9 kB	0 B
`dotcom-rendering/dist/GuideAtomWrapper-importable.web.********************.js`	790 B	0 B
`dotcom-rendering/dist/HeaderTopBar-importable.web.********************.js`	11.1 kB	+2 B (0%)
`dotcom-rendering/dist/index.web.********************.js`	37.8 kB	0 B
`dotcom-rendering/dist/InstagramBlockComponent-importable.web.********************.js`	3.59 kB	+2 B (0%)
`dotcom-rendering/dist/InteractiveBlockComponent-importable.web.********************.js`	5.94 kB	-2 B (0%)
`dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.web.********************.js`	3.79 kB	0 B
`dotcom-rendering/dist/InteractiveSupportButton-importable.web.********************.js`	4.12 kB	0 B
`dotcom-rendering/dist/KeyEventsCarousel-importable.web.********************.js`	2.96 kB	0 B
`dotcom-rendering/dist/KnowledgeQuizAtom-importable.web.********************.js`	3.52 kB	0 B
`dotcom-rendering/dist/LatestLinks-importable.web.********************.js`	1.17 kB	0 B
`dotcom-rendering/dist/LightboxHash-importable.web.********************.js`	430 B	0 B
`dotcom-rendering/dist/LightboxJavascript-importable.web.********************.js`	4.43 kB	+1 B (0%)
`dotcom-rendering/dist/LiveBlogEpic-importable.web.********************.js`	3.04 kB	0 B
`dotcom-rendering/dist/Liveness-importable.web.********************.js`	3.34 kB	0 B
`dotcom-rendering/dist/ManyNewsletterSignUp-importable.web.********************.js`	4.98 kB	0 B
`dotcom-rendering/dist/MapEmbedBlockComponent-importable.web.********************.js`	5.55 kB	+3 B (0%)
`dotcom-rendering/dist/Metrics-importable.web.********************.js`	2.39 kB	0 B
`dotcom-rendering/dist/MostViewedFooter-importable.web.********************.js`	5.62 kB	0 B
`dotcom-rendering/dist/MostViewedFooterData-importable.web.********************.js`	7.91 kB	0 B
`dotcom-rendering/dist/MostViewedRightWrapper-importable.web.********************.js`	3.9 kB	0 B
`dotcom-rendering/dist/OnwardsUpper-importable.web.********************.js`	4.17 kB	0 B
`dotcom-rendering/dist/PersonalityQuizAtom-importable.web.********************.js`	3.66 kB	0 B
`dotcom-rendering/dist/ProfileAtom-importable.web.********************.js`	547 B	0 B
`dotcom-rendering/dist/ProfileAtomWrapper-importable.web.********************.js`	810 B	0 B
`dotcom-rendering/dist/PulsingDot-importable.web.********************.js`	744 B	0 B
`dotcom-rendering/dist/QandaAtom-importable.web.********************.js`	542 B	0 B
`dotcom-rendering/dist/ReaderRevenueDev-importable.web.********************.js`	485 B	0 B
`dotcom-rendering/dist/readerRevenueDevUtils.web.********************.js`	2.98 kB	0 B
`dotcom-rendering/dist/ReaderRevenueLinks-importable.web.********************.js`	5.05 kB	0 B
`dotcom-rendering/dist/RecipeMultiplier-importable.web.********************.js`	3.16 kB	0 B
`dotcom-rendering/dist/RelativeTime-importable.web.********************.js`	1.92 kB	0 B
`dotcom-rendering/dist/RichLinkComponent-importable.web.********************.js`	6.32 kB	0 B
`dotcom-rendering/dist/SecureSignupIframe-importable.web.********************.js`	4.93 kB	0 B
`dotcom-rendering/dist/SendAMessage-importable.web.********************.js`	4.38 kB	0 B
`dotcom-rendering/dist/SendTargetingParams-importable.web.********************.js`	2.04 kB	0 B
`dotcom-rendering/dist/sentry.web.********************.js`	773 B	0 B
`dotcom-rendering/dist/SetABTests-importable.web.********************.js`	3.46 kB	0 B
`dotcom-rendering/dist/SetAdTargeting-importable.web.********************.js`	481 B	0 B
`dotcom-rendering/dist/shimport.web.********************.js`	2.78 kB	0 B
`dotcom-rendering/dist/ShowHideContainers-importable.web.********************.js`	642 B	0 B
`dotcom-rendering/dist/ShowMore-importable.web.********************.js`	5.59 kB	0 B
`dotcom-rendering/dist/SignInGateMain.web.********************.js`	3.86 kB	+5 B (0%)
`dotcom-rendering/dist/SignInGateMainCheckoutComplete.web.********************.js`	4.94 kB	0 B
`dotcom-rendering/dist/SignInGateSelector-importable.web.********************.js`	3.57 kB	0 B
`dotcom-rendering/dist/SlotBodyEnd-importable.web.********************.js`	8.77 kB	0 B
`dotcom-rendering/dist/Snow-importable.web.********************.js`	3.02 kB	0 B
`dotcom-rendering/dist/SpotifyBlockComponent-importable.web.********************.js`	5.39 kB	0 B
`dotcom-rendering/dist/StickyBottomBanner-importable.web.********************.js`	5.92 kB	0 B
`dotcom-rendering/dist/SubNav-importable.web.********************.js`	2.37 kB	0 B
`dotcom-rendering/dist/SupportTheG-importable.web.********************.js`	5.16 kB	0 B
`dotcom-rendering/dist/TableOfContents-importable.web.********************.js`	3.05 kB	0 B
`dotcom-rendering/dist/TimelineAtom-importable.web.********************.js`	1.22 kB	0 B
`dotcom-rendering/dist/TweetBlockComponent-importable.web.********************.js`	1.01 kB	0 B
`dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.web.********************.js`	3.6 kB	0 B
`dotcom-rendering/dist/VideoFacebookBlockComponent-importable.web.********************.js`	5.57 kB	0 B
`dotcom-rendering/dist/VineBlockComponent-importable.web.********************.js`	3.46 kB	0 B
`dotcom-rendering/dist/WeatherWrapper-importable.web.********************.js`	5.41 kB	0 B
`dotcom-rendering/dist/YoutubeBlockComponent-importable.web.********************.js`	3.73 kB	0 B

_{compressed-size-action}

mxdvl

Sure thing!

Why did we need to keep it for LiveBlog?

arelra · 2023-11-21T13:36:07Z

Why did we need to keep it for LiveBlog?

Also in the PR description:

The epic.interactivity.cy.js LiveBlogEpic test still asserts on data-cy as it looks like its rendered output it not coming from DCR.

mxdvl · 2023-11-21T13:48:03Z

Why did we need to keep it for LiveBlog?

Also in the PR description:

The epic.interactivity.cy.js LiveBlogEpic test still asserts on data-cy as it looks like its rendered output it not coming from DCR.

Should we fix it upstream?

arelra · 2023-11-21T13:51:21Z

Should we fix it upstream?

Good point will do

arelra added 3 commits November 16, 2023 17:37

Replace data-cy with data-testid

ae0f114

Remove duplicates

13cbf3a

Replace data-cypress with data-testid

1457e09

arelra requested a review from a team as a code owner November 16, 2023 17:57

github-actions Bot added the dotcom-rendering label Nov 16, 2023

Keep data-cy for LiveBlogEpic

c510432

arelra force-pushed the ravi/replace-data-cy-data-testid branch from 2f3a605 to c510432 Compare November 16, 2023 18:08

mxdvl approved these changes Nov 21, 2023

View reviewed changes

arelra merged commit 20cd3f8 into main Nov 21, 2023

arelra deleted the ravi/replace-data-cy-data-testid branch November 21, 2023 13:48

mxdvl mentioned this pull request Nov 21, 2023

The data-cy attribute has been deprecated in favour of data-testid guardian/support-dotcom-components#1008

Open

arelra mentioned this pull request Nov 22, 2023

Replace data-cy with data-testid guardian/support-dotcom-components#1010

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace `data-cy` with `data-testid`#9541

Replace `data-cy` with `data-testid`#9541
arelra merged 4 commits intomainfrom
ravi/replace-data-cy-data-testid

arelra commented Nov 16, 2023 •

edited

Loading

Uh oh!

github-actions Bot commented Nov 16, 2023 •

edited

Loading

Uh oh!

mxdvl left a comment •

edited

Loading

Uh oh!

arelra commented Nov 21, 2023

Uh oh!

mxdvl commented Nov 21, 2023 •

edited

Loading

Uh oh!

arelra commented Nov 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

arelra commented Nov 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this change?

Uh oh!

github-actions Bot commented Nov 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mxdvl left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arelra commented Nov 21, 2023

Uh oh!

mxdvl commented Nov 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arelra commented Nov 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

arelra commented Nov 16, 2023 •

edited

Loading

github-actions Bot commented Nov 16, 2023 •

edited

Loading

mxdvl left a comment •

edited

Loading

mxdvl commented Nov 21, 2023 •

edited

Loading