Change dotcoom rendering parameter (?guui => ?dcr=true/false)#21753
Merged
philmcmahon merged 2 commits intomasterfrom Aug 21, 2019
Merged
Change dotcoom rendering parameter (?guui => ?dcr=true/false)#21753philmcmahon merged 2 commits intomasterfrom
philmcmahon merged 2 commits intomasterfrom
Conversation
|
PRbuilds results: Screenshots 💚 A11y validation 💚 Microdata Validation Apache Benchmark Load Testing LightHouse Reporting --automated message |
| } | ||
|
|
||
| private def getJson(article: ArticlePage)(implicit request: RequestHeader): List[(String, Object)] = { | ||
| val contentFieldsJson = if (request.isGuuiJson) List( |
Contributor
There was a problem hiding this comment.
It looks pretty correct to get rid of guuiJson to just be using forceDCR.
But just to make 100% sure, can you check that .json?dcr=true on an article definitely still works locally?, and produces a different result to .json?dcr=false, which should be equivalent to just .json
Contributor
Author
There was a problem hiding this comment.
Yep have verified this!
philmcmahon
force-pushed
the
pm-migrate-dcr-parameter
branch
from
e59759f to
8521163
Compare
gtrufitt
approved these changes
Aug 21, 2019
|
Seen on PROD (merged by @philmcmahon 19 minutes and 12 seconds ago)
|
rtyley
added a commit
to guardian/dotcom-rendering
that referenced
this pull request
Aug 18, 2020
guardian/frontend#21753 made `?dcr` the way to control whether or not a given article is rendered by DCR, but this was not documented in DCR's README.md!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Renames the parameter we use to force dotcom rendering. Currently we have
guuiandguui=false. In this bright new world we will havedcr=trueanddcr=falsewhich seems more sensible.It's still an acronym though so I'm happy for something else, just not sure
rendering=would be that good either. I've stuck a comment in where the value is read from the query string, hopefully that should minimise confusion.Tested