get tag combiner pages running in DCR #27953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andrew-nowak
force-pushed
the
an/tag-combiners-dcr
branch
2 times, most recently
from
267e828 to
c31436b
Compare
Contributor
|
Wow this is an awesome effort, thanks so much for getting this up and running @andrew-nowak! 👏 It would be great if we could add some basic docs around this, or at least make this article more discoverable. Tag combiner pages are a real power tool for devs and product-minded colleagues, useful for debugging and surfacing examples of specific content types. |
andrew-nowak
force-pushed
the
an/tag-combiners-dcr
branch
from
c31436b to
32f73e7
Compare
andrew-nowak
force-pushed
the
an/tag-combiners-dcr
branch
from
32f73e7 to
d3283b4
Compare
SiAdcock
approved these changes
Jun 5, 2025
Contributor
SiAdcock
left a comment
SiAdcock
left a comment
There was a problem hiding this comment.
This is awesome thanks @andrew-nowak 💎
andrew-nowak
changed the title
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (merged by @andrew-nowak 12 minutes and 13 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @andrew-nowak 12 minutes and 19 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
What does this change?
A tag combiner page is just a tag page with a fancier query... right?
If we can render a tag page in DCR, then surely we can also render a tag combiner page!
(Yes we can, just the routes regex needs teaching that the
.jsonisn't part of the right tag, and a couple extra fields sent in the DCR model for the tag combiner page).Screenshots
Checklist
data/databasefiles generated by tests are committed with this PR (the tests will fail in CI if you've forgotten to do this)