Conversation
c906db7 to
3a6438c
Compare
Co-authored-by: Marjan Kalanaki <marjan.kalanaki@guardian.co.uk>
3a6438c to
9857b75
Compare
| if (Configuration.environment.stage == "CODE") { | ||
| logInfoWithCustomFields( | ||
| s"Pressed data for front $path : ${Json.stringify(Json.toJson(pressedFronts.full))} ", | ||
| s"Pressed data for front $path", |
There was a problem hiding this comment.
Logging the entire front JSON was making facia-press logs unusable and I was not able to test my changes.
Logs were too big and it was impossible to select a larger than a few minutes time range. The response was larger than the allowed size
In a following PR I will delete this entire block of code.
frontend/facia-press/app/frontpress/FapiFrontPress.scala
Lines 263 to 271 in 6e2c33e
|
|
||
| def run(): Future[Unit] = { | ||
| if (R2PagePressServiceSwitch.isSwitchedOn) { | ||
| log.info("R2PagePressJob starting") |
There was a problem hiding this comment.
I really doubt this job is doing anything so I haven't been able to test it successfully. By looking at the code, R2PagePressNotifier publishes SNS notifications and pushes jobs to two queues. There's one for re-pressing R2 pages and one for taking them down. R2PressPageJob listens to the queues and performs the operation.
I tried to re-press an R2 page in PROD and
- I can't see any of these logs.
- The S3 object for the pressed page is not in the bucket.
I haven't tested the takedown path because this is done by CP when they publish the old R2 articles in Composer and results in 404 for the old url.
I propose we ignore this for the purposes of this PR and maybe remove any unnecessary infrastructure from R2 pressing. We've discussed in the past that just pressing and putting in the bucket should be enough.
|
Seen on ADMIN-PROD (merged by @ioannakok 9 minutes and 56 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @ioannakok 11 minutes and 7 seconds ago)
|
Closes #26516
Background
There are two queues in the fronts architecture:
FrontPressCron. It receives notifications from theRefreshFrontsJobin the admin app on a cron schedule.ToolPressQueueWorker. It receives press jobs from the fronts tool whenever a front gets updated.See more about fronts architecture here
What does this change?
This PR updates the code for these two queues to AWS SDK v2.
Why?
AWS SDK v1 reaches end-of-support on 31 of December
Screenshots
Front pages are successfully pressed both when the cron job triggers them and when they are changed from the Fronts Tool.
Checklist