Closed
Conversation
Contributor
Author
|
Because my incorrect Prettification has resulted in hundreds of lines of changes, we're parking this pending @philmcmahon and @twrichards proposals about implementing Prettier and eslint for Giant. There's nothing remotely urgent about this PR so it can wait until the linting is in place and then we can update these PRs to comply. |
Contributor
Author
|
Back with me to redo from scratch following lint rules change |
Contributor
Author
|
Replaced by #513 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
How to test
NOT TESTED OR EVEN SEEN LOCALLY OR IN PLAYGROUND because I don't know how to make a local dev environment, and I'm loathe to attempt to deploy this to playground while everyone is away. So, apologies, can you perhaps try it locally or in playground, when you get to this.
Chip truncation test:
Multi-line wrapping test
Asterisk removal test
How can we measure success?
Fewer confused users. Or at least, we will be less responsible for their confusion.
Have we considered potential risks?
Yeah, Luke thinks vibe coding is a thing