Merged
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
On @twrichards suggestion here, I did some basic performance testing of nothing vs gzip vs brotli compression in giant.
For a worskspace with a json blob that's 11.63MB, I got the following timings before the server started serving content (after several refreshes to reduce any first load perfomance impact):
Nothing: 3.8s
Brotli: 4.5s
Gzip: 4s
Compression wise, the results were:
Brotli: 76% (2.83MB)
Gzip: 75% (2.96MB)
With the above in mind, I think gzip compression is the sweet spot. From some basic research, brotli is also generally recommended for dynamically generated files - brotli is more for stuff that is getting cached so you don't pay the higher compression cost on every request.
How to test
Tested on playground!