Bump Jackson from 2.19.2 to 2.21.2 to fix GHSA-72hv-8253-57qq#178
Merged
Conversation
jorgeazevedo
added
the
maintenance
Contributor
Author
|
@rtyley am I right in thinking that these tests are currently broken? I tried running it against main (on a different branch, to avoid making main red) and it's also failed after it exceeds the max amount of retries/time https://github.com/guardian/prout/actions/runs/24146534954/job/70461782957 I wonder if the same issue you were trying to fix here #146 |
rtyley
added a commit
that referenced
this pull request
Apr 8, 2026
As detailed in this PR: * rtyley/play-git-hub#18 ...there are multiple issues affecting the flakiness of Prout's integration tests, and fixing them all involved some pretty big changes to `play-git-hub`, released with v10 of that library: * https://github.com/rtyley/play-git-hub/releases/tag/v10.0.0 Unfortunately updating Prout to adapt to that new version of `play-git-hub` is a big job, especially the migration from `Future` to `IO` - the PR to do that isn't yet completed: * #146 ...in the meantime, Prout's integration tests are failing frequently: * #178 (comment) This change disables Prout's integration tests - we'll just have to double-check after deploy that Prout is still working!
Member
Gah, yes, unfortunately so. I've opened this PR to disable those flakey tests: |
Contributor
Author
Member
jorgeazevedo
force-pushed
the
ja-fix-jackson-dos-vulnerability
branch
from
a28b76e to
7f34160
Compare
rtyley
approved these changes
Apr 9, 2026
|
Seen on PROD (merged by @jorgeazevedo 9 hours, 9 minutes and 31 seconds ago) Please check your changes! Sentry Release: prout |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Bumps Jackson dependencies from 2.19.2 to 2.21.2 to fix GHSA-72hv-8253-57qq