This repository was archived by the owner on Dec 6, 2022. It is now read-only.
Merged
Conversation
jamie-lynch
force-pushed
the
process-brand-icons
branch
from
7ac44b8 to
02b72ce
Compare
SiAdcock
approved these changes
Nov 26, 2021
Contributor
SiAdcock
left a comment
SiAdcock
left a comment
There was a problem hiding this comment.
This is awesome, thanks so much @jamie-lynch 💎
It's probably a good idea to move icons with brand colours onto their own frame in Figma so we don't need to keep a list of those icons in here. I'll check with Akemi to see if she's happy with this. Let me know if you can think of other ways we can improve the organisation in Figma to make this script more efficient
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
The
get-iconsscripts pull in the svg source for icons from the Figma API and undertakes a small amount of processing to align the source with the expected format. Previously, this process ignored brand icons as they did not follow the standard pattern. This PR updates the process to account for those differences.The key difference is that the
fillattribute is not removed from child components of the<svg>tag. There were some other inconsistencies which this script does not respect. It is hoped that those changes were the results of inconsistent practice and not deliberate differences and, therefore, the icons output by this script will remain visually consistent, despite the subtle changes to the source.What does this change?