This repository was archived by the owner on Jan 25, 2018. It is now read-only.
More fixes towards 14 1 0#630
Merged
n8fr8 merged 5 commits intoguardianproject:masterfrom Feb 23, 2015
Merged
Conversation
I had some issues translating some example code to ChatSecure here, so some of the argument classes and generics weren't correct. This corrects them. refs #4472 https://dev.guardianproject.info/issues/4472
This marks the APK with the actual version, not just the version that is in AndroidManifest.xml. If this build is on a signed tag that matches the versionName in AndroidManifest.xml, then the APK will be a proper release APK. Otherwise, it'll get the whole `git describe` string to mark it as an non-release build.
…ations Some languages are more verbose, or also have longer spellings. Long languages on a small screen mean the buttons get obscured. This looks like a big change because I also formatted the file with the Android formatter. But literally I just changed the most external item from a LinearLayout to a ScrollView. closes #4540 https://dev.guardianproject.info/issues/4540
The strings used as keys in SharedPreferences should never be translated, they are used as a unique value to look up the preference value in the stored preferences. If this value gets translated, then that means it will represent a new entry in the SharedPreferences.
It is better to have one long delay when the app starts, then a shorter delay after the user enters her password (i.e. when SQLCipher and IOCipher are actually used for the first time).
eighthave
referenced
this pull request
in n8fr8/ChatSecureAndroid
Feb 19, 2015
Linkify code expects a Spannable which only exists if the message contains text and not a media object
Member
Author
|
Also, n8fr8@0bbb908 should not be included since eighthave/ChatSecureAndroid@df3cc88 fixes that issue. |
Member
|
Well, my changes still make sense, but aren't necessary, true. Ultimately, if a message has a mime-type for media, there will be nothing to linkify. |
Member
Author
|
We might be able to linkify media in the message using Linkify, that's why I stuck it where I did. But I haven't yet looked into the details yet. For example, perhaps it would linkify a QR Code image. But maybe that's just silly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a collection of fixes for issues that I found while working on the IOCipher integration. Full comments are in the commit messages.