Skip to content

Conversation

@syphyr
Copy link
Contributor

@syphyr syphyr commented Mar 17, 2025

Fix Orbot constants and set default dns port to 9053 which is the same default as c-tor.

@syphyr
Copy link
Contributor Author

syphyr commented Mar 17, 2025

@meenbeese could you please review this?

@bitmold
Copy link
Collaborator

bitmold commented Mar 18, 2025

One thing that's annoying here is that many translations actually have this hardcoded to port 5400, not just the default.

One way would just be to update them all?

For example:

~/orbot/app/src/main/res/values-az/strings.xml:
   87      <string name="pref_transport_dialog">TransProxy Port Konfiqurasiyası</string>
   88      <string name="pref_dnsport_title">Tor DNS Port</string>
   89:     <string name="pref_dnsport_summary">Torun təklif etdiyi Port DNS işləyir (standart: 5400, yaxud söndürmək üçün 0)</string>
   90      <string name="pref_dnsport_dialog">DNS Port Konfiqurasiyası</string>
   91      <string name="pref_torrc_title">Torrc Xüsusi Konfiqurasiya</string>

~/orbot/app/src/main/res/values-be/strings.xml:
   89      <string name="pref_transport_dialog">Налада порта празрыстага проксі</string>
   90      <string name="pref_dnsport_title">Порт DNS Tor</string>
   91:     <string name="pref_dnsport_summary">Порт, на якім Tor прапануе свой DNS (па змаўчанні: 5400, 0 - для адключэння)</string>
   92      <string name="pref_dnsport_dialog">Налада порта DNS</string>
   93      <string name="pref_torrc_title">Карыстальніцкія налады Torrc</string>

~/orbot/app/src/main/res/values-bg/strings.xml:
   87      <string name="pref_transport_dialog">Настройка на порта на прозрачен сървър за прокси</string>
   88      <string name="pref_dnsport_title">Порт за DNS на Тор</string>
   89:     <string name="pref_dnsport_summary">Порт, на който Тор предлага услуга за DNS (подразбиран: 5400 или 0 за изключване)</string>
   90      <string name="pref_dnsport_dialog">Настройка на порта за DNS</string>
   91      <string name="pref_torrc_title">Потребителски настройки на Torrc</string>

@syphyr
Copy link
Contributor Author

syphyr commented Mar 18, 2025

One thing that's annoying here is that many translations actually have this hardcoded to port 5400, not just the default.

One way would just be to update them all?

Thanks for mentioning that. I have fixed it by updating them all with find . -type f -name 'strings.xml' | xargs sed -i 's/5400/9053/g'

@meenbeese
Copy link
Contributor

@meenbeese could you please review this?

Thanks but can you rebase this on #1216? Otherwise, I will have huge conflicts once this is merged.

syphyr added 2 commits April 5, 2025 00:02
Fix Orbot constants and set default dns port to 9053
which is the same default as c-tor.
Changes port from 5400 to 9053
@syphyr
Copy link
Contributor Author

syphyr commented Apr 4, 2025

@meenbeese could you please review this?

Thanks but can you rebase this on #1216? Otherwise, I will have huge conflicts once this is merged.

Done

@n8fr8
Copy link
Member

n8fr8 commented Apr 15, 2025

I feel like there is a reason I chose 5400 and/or didn't use 9053...

@syphyr
Copy link
Contributor Author

syphyr commented Apr 15, 2025

Currently, the default setting for the dns port is set to auto. So, Orbot will start looking for ports starting at 5400. It also seems like 9053 is a better starting point since the chance of the higher port number being taken by something else would be less.

@n8fr8 n8fr8 merged commit c98053b into guardianproject:master Apr 16, 2025
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants