modify Makefile so that tor-android can be compiled on MacOS#186
Merged
bitmold merged 1 commit intoguardianproject:masterfrom Feb 6, 2026
Merged
modify Makefile so that tor-android can be compiled on MacOS#186bitmold merged 1 commit intoguardianproject:masterfrom
bitmold merged 1 commit intoguardianproject:masterfrom
Conversation
Contributor
|
Thanks so much for figuring this out! I just also confirmed that everything still works fine on Linux after applying your changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
several build steps were failing.
libtoolduring the configure phase before compiling.However generating the resulting lib using that
libtoolfailed (Maybe because that isn't the gnu libtool?). Setting the environment variables forARto a libtool provided by the NDK as well as setting theCHOSTallowed to overcome that issue.jni_md.hwas missing. Adding the correct include path to theCPPFLAGS, fixed that.