4010 migrate fingerprint data#4027
Merged
ilija-lazoroski merged 2 commits intodevelopfrom Jan 18, 2024
Merged
Conversation
cakekoa
reviewed
Jan 17, 2024
| from typing import List, Mapping, MutableMapping, Sequence | ||
|
|
||
| from agentpluginapi import ExploiterResult, PingScanData, PortScanData, TargetHost | ||
| from agentpluginapi import ExploiterResult, FingerprintData, PingScanData, PortScanData, TargetHost |
Contributor
There was a problem hiding this comment.
Is this under the line length limit?
Contributor
Author
There was a problem hiding this comment.
Black is formatting it like this, so I guess it is.
cakekoa
approved these changes
Jan 17, 2024
611622b to
8fa7c72
Compare
d1a98b4 to
e3ba2bb
Compare
Migrated to agentpluginapi
e3ba2bb to
fdea206
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4027 +/- ##
===========================================
- Coverage 77.43% 77.42% -0.02%
===========================================
Files 454 453 -1
Lines 14366 14355 -11
===========================================
- Hits 11125 11114 -11
Misses 3241 3241 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes part of #4010 .
PR Checklist
Testing Checklist