Skip to content

4010 migrate fingerprint data#4027

Merged
ilija-lazoroski merged 2 commits intodevelopfrom
4010-migrate-fingerprint-data
Jan 18, 2024
Merged

4010 migrate fingerprint data#4027
ilija-lazoroski merged 2 commits intodevelopfrom
4010-migrate-fingerprint-data

Conversation

@ilija-lazoroski
Copy link
Copy Markdown
Contributor

@ilija-lazoroski ilija-lazoroski commented Jan 17, 2024

What does this PR do?

Fixes part of #4010 .

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

from typing import List, Mapping, MutableMapping, Sequence

from agentpluginapi import ExploiterResult, PingScanData, PortScanData, TargetHost
from agentpluginapi import ExploiterResult, FingerprintData, PingScanData, PortScanData, TargetHost
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this under the line length limit?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black is formatting it like this, so I guess it is.

@ilija-lazoroski ilija-lazoroski force-pushed the 4010-migrate-i-tcp-port-selector branch from 611622b to 8fa7c72 Compare January 18, 2024 08:12
@ilija-lazoroski ilija-lazoroski force-pushed the 4010-migrate-fingerprint-data branch from d1a98b4 to e3ba2bb Compare January 18, 2024 08:24
Base automatically changed from 4010-migrate-i-tcp-port-selector to develop January 18, 2024 08:42
@ilija-lazoroski ilija-lazoroski force-pushed the 4010-migrate-fingerprint-data branch from e3ba2bb to fdea206 Compare January 18, 2024 08:43
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8fa7c72) 77.43% compared to head (fdea206) 77.42%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4027      +/-   ##
===========================================
- Coverage    77.43%   77.42%   -0.02%     
===========================================
  Files          454      453       -1     
  Lines        14366    14355      -11     
===========================================
- Hits         11125    11114      -11     
  Misses        3241     3241              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ilija-lazoroski ilija-lazoroski merged commit 5444963 into develop Jan 18, 2024
@ilija-lazoroski ilija-lazoroski deleted the 4010-migrate-fingerprint-data branch January 18, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants