Skip to content

Conversation

thebigbone
Copy link
Contributor

No description provided.

@zsimjee
Copy link
Collaborator

zsimjee commented Mar 25, 2024

This looks great! Please run make autoformat and push up those changes (it's the auto-linting stuff to pass checks). Do you also mind syndicating these changes to the validator package here - https://github.com/guardrails-ai/endpoint_is_reachable?

@thebigbone
Copy link
Contributor Author

thebigbone commented Mar 27, 2024

This looks great! Please run make autoformat and push up those changes (it's the auto-linting stuff to pass checks).

Oh, apologies for not running the tests. I will run it and push the new commit.

Do you also mind syndicating these changes to the validator package here - https://github.com/guardrails-ai/endpoint_is_reachable?

Sure thing!

@zsimjee
Copy link
Collaborator

zsimjee commented Mar 27, 2024

Thanks so much! Ready to merge once checks run

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@60c5ef6). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #665   +/-   ##
=======================================
  Coverage        ?   80.38%           
=======================================
  Files           ?      123           
  Lines           ?     7035           
  Branches        ?        0           
=======================================
  Hits            ?     5655           
  Misses          ?     1380           
  Partials        ?        0           
Flag Coverage Δ
unittests 80.38% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zsimjee zsimjee merged commit 24383b9 into guardrails-ai:main Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants