Skip to content

use HTTPStatus.OK instead of literal status code 200 #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2024
Merged

use HTTPStatus.OK instead of literal status code 200 #665

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29b72c0
use HTTPStatus.OK instead of literal status code 200
thebigbone Mar 23, 2024
89b9fb4
ran autoformat for fixing linting errors
thebigbone Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion guardrails/validators/endpoint_is_reachable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from http import HTTPStatus
from typing import Any, Dict

from guardrails.logger import logger
Expand Down Expand Up @@ -31,7 +32,7 @@ def validate(self, value: Any, metadata: Dict) -> ValidationResult:
# Check that the URL exists and can be reached
try:
response = requests.get(value)
if response.status_code != 200:
if response.status_code != HTTPStatus.OK:
return FailResult(
error_message=f"URL {value} returned "
f"status code {response.status_code}",
Expand Down