Skip to content

Conversation

CalebCourier
Copy link
Collaborator

Previously, if validation failed when the on_fail action was noop, the output that failed validation would be returned through the chain.

Now we raise an exception if validation fails with noop in guard runnable by inspecting ValidationOutcome.validation_passed.

@CalebCourier CalebCourier requested a review from a team July 31, 2024 16:23
@dtam dtam merged commit 70fa5ac into main Jul 31, 2024
@dtam dtam deleted the fix-lc-w-noop branch July 31, 2024 16:35
@zsimjee zsimjee added this to the v0.5.3 Release Tracker milestone Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants