Skip to content

Fix Langchain Integration when using No-Op #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Fix Langchain Integration when using No-Op #980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions guardrails/integrations/langchain/guard_runnable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
from guardrails.guard import Guard
from guardrails.errors import ValidationError
from guardrails.classes.output_type import OT
from guardrails.classes.validation_outcome import ValidationOutcome


class GuardRunnable(BaseRunnable):
Expand All @@ -12,9 +13,9 @@ def __init__(self, guard: Guard):
self.guard = guard

def _validate(self, input: str) -> OT:
response = self.guard.validate(input)
response: ValidationOutcome[OT] = self.guard.validate(input)
validated_output = response.validated_output
if not validated_output:
if not validated_output or response.validation_passed is False:
raise ValidationError(
(
"The response from the LLM failed validation!"
Expand Down
2 changes: 1 addition & 1 deletion tests/integration_tests/integrations/langchain/test_guard_runnable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def guard_runnable():
.use(
RegexMatch("Ice cream", match_type="search", on_fail="refrain"), on="output"
)
.use(ReadingTime(0.05, on_fail="refrain"))
.use(ReadingTime(0.05, on_fail="noop"))
)


Expand Down