Weekend Update #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saving Dockerfile implementations for later. Want to build some units first.
For testing units for api. leaked handles tends to come up with tape
Using 's in folder and object names, consistent to tape and restify docs: https://www.npmjs.com/package/tape#usage https://github.com/shermify/restify-example/tree/master/routes
Needed for watch Developer moving to this from a Netlify environment where everything was scaffold :|
Test for Result entity
Validation moved into it's own utility for security Iterators moved out of testing into route object
Command and paramter greenlights for more thorough testing of function
Left out match caps of punctuation. Needed to add spaces for metadata description
Finished moving time and patterns out of result.tests.js for central validation Finished moving iterators into routes/results
Removed time function from tests
Moved to routes/results out of testing, for reuse in handlers
Ugly, but working. Need to clean up by passing results. Reference: https://medium.com/javascript-scene/javascript-factory-functions-with-es6-4d224591a8b1#fb43
Switch to fractal directory structure Needed clarity and simplicity before building factory pattern Switching to objects with default parameters and methods instead of pure functions, using 'this'
Needed to fix nested requires
Stashed factory mixins feature for backend. Trying to build instead of using mocks in tests, and objects in rest result. Issue with position, value in key. Stashed, and moving to work on frontend
Stayed with begin as default, to allow for property access without throwing error Also fixed location with spread in createLocation
Added fastify for GET and POST requests No events, too close to deadline
Need build directory in api/Dockerfile dashboard/ from create-react-app
Simple styles, attempt at integrating tailwind and storybook failed. References: storybookjs/storybook#4038 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello:
Checking in, in case weekends count against the five day deadline, and to share what I consider production ready code.
Features:
Todo: