Skip to content

Conversation

@guendev
Copy link
Owner

@guendev guendev commented Oct 21, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 21, 2025 04:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends the Apollo Client configuration capabilities by exposing additional ApolloClient options (assumeImmutableResults, dataMasking, defaultOptions, localState, queryDeduplication) through the shared configuration interface. It also improves configuration handling by filtering out module-specific options when passing config to client instances.

Key changes:

  • Extended ApolloSharedConfig interface to include more ApolloClient options via Pick utility type
  • Added a type-safe pick utility function for selective property extraction
  • Updated configuration merging logic to properly filter and apply the new options
  • Translated Vietnamese comments to English for consistency

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/nuxt/src/type.ts Extended ApolloSharedConfig interface with additional ApolloClient options; removed duplicate devtools and defaultOptions definitions; translated comments to English
packages/nuxt/src/runtime/utils/pick.ts Added new type-safe utility function for picking properties from objects
packages/nuxt/src/runtime/utils/createApolloClient.ts Updated client creation to use the new pick utility for selecting configuration options; improved defaultOptions merging logic
packages/nuxt/src/runtime/plugin.ts Added autoImports to the omit list when passing config to client instances
packages/nuxt/playground/nuxt.config.ts Added example configuration demonstrating the new defaultOptions support at both global and client-specific levels
.changeset/chatty-states-shave.md Added changeset documenting the feature addition

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@guendev guendev merged commit 5fd1378 into main Oct 21, 2025
3 checks passed
@guendev guendev deleted the fix-config branch October 25, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants