Merged
Conversation
Query-level option overrides were never sent to the CLI — the subprocess is configured once at startup. Remove the dead schema, validation, and merge functions.
Stream.create no longer forwards opts to the server. The
{:query_stream, prompt} tuple replaces {:query_stream, prompt, opts}.
execute_request always passes [session_id: state.session_id] directly.
Delete tests for removed functions. Update GenServer calls to use
the new {:query_stream, prompt} tuple without opts.
These options were never actually sent to the CLI. Session-level configuration is the correct pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@query_opts_schema,validate_query_options/1,merge_options/2, andquery_schema/0fromClaudeCode.Options— these were never sent to the CLI{:query_stream, prompt, opts}tuple to{:query_stream, prompt}throughout the pipelineSession.Server.execute_requestnow passes only[session_id: state.session_id]to the adapterContext
The CLI subprocess is configured once at startup. Query-level option overrides (model, tools, system prompt, etc.) were validated and merged in
Session.Serverbut the adapter only ever read:session_idfrom the merged opts. This created a false abstraction where users believed they could reconfigure the session per-stream/3call.stream/3still accepts:timeoutand:filteropts — these are consumed locally byStream.createand never sent to the server.Test plan
mix qualitypasses (compile, format, credo, dialyzer)mix testpasses (1490 tests, 2 pre-existing failures unrelated to changes)session_idcapture in test adapter)