Problem
When CI detects style drift, the error message tells contributors:
Run 'dotnet jb cleanupcode Terminal.Gui.Editor.slnx --profile="TG.Editor Full Cleanup"' locally and commit the result.
This is incomplete - it omits the critical --exclude and --no-build flags that CI itself uses. A contributor who follows this advice verbatim will:
- Get build errors due to missing
#nullable and related warnings
- See 55+ files changed because the forked AvaloniaEdit files (
Document/, Utils/, Search/) get reformatted
The actual CI command is:
dotnet jb cleanupcode Terminal.Gui.Editor.slnx \
--profile="TG.Editor Full Cleanup" \
--no-build \
--exclude="third_party/**/*;src/Terminal.Gui.Editor/Document/**/*;src/Terminal.Gui.Editor/Utils/**/*;src/Terminal.Gui.Editor/Search/**/*"
Suggested fix
Update the echo in .github/workflows/ci.yml (or wherever the style-drift check lives) to print the full command including --no-build and --exclude flags, so contributors can copy-paste it directly.
Alternatively, add a scripts/cleanupcode.sh (or .ps1) wrapper that encapsulates the correct invocation and reference that in both CI and the error message.
Context
Reported by @BDisp in PR #195.
Problem
When CI detects style drift, the error message tells contributors:
This is incomplete - it omits the critical
--excludeand--no-buildflags that CI itself uses. A contributor who follows this advice verbatim will:#nullableand related warningsDocument/,Utils/,Search/) get reformattedThe actual CI command is:
Suggested fix
Update the
echoin.github/workflows/ci.yml(or wherever the style-drift check lives) to print the full command including--no-buildand--excludeflags, so contributors can copy-paste it directly.Alternatively, add a
scripts/cleanupcode.sh(or.ps1) wrapper that encapsulates the correct invocation and reference that in both CI and the error message.Context
Reported by @BDisp in PR #195.