Skip to content

Fix release build break in ted caused by malformed conditional and missing System.Text import#214

Merged
tig merged 2 commits into
developfrom
copilot/fix-release-v2-2-1-develop-163
May 22, 2026
Merged

Fix release build break in ted caused by malformed conditional and missing System.Text import#214
tig merged 2 commits into
developfrom
copilot/fix-release-v2-2-1-develop-163

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 22, 2026

Release run 2.2.1-develop.163 failed during the cross-platform build matrix due to a compile error in examples/ted/TedApp.cs. The file had a malformed if statement and a missing using required by Encoding.

  • Compile break in settings dialog flow

    • Repaired corrupted conditional in ShowSettingsDialog:
      • Saveif (dialog.WasAccepted)if (dialog.WasAccepted)
    • Preserved the intended behavior: apply dialog values and persist view settings only when accepted.
  • Missing namespace import

    • Added using System.Text; at file scope to resolve Encoding usage in UpdateContentSizeStatus.
using System.Text;

// ...

if (dialog.WasAccepted)
{
    dialog.ApplyTo (Editor);
    SaveViewSettings ();
}

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • www.jetbrains.com
    • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/.nuget/packages/jetbrains.resharper.globaltools/2026.1.1/tools/net8.0/any/cleanupcode.unix.runtimeconfig.json /home/REDACTED/.nuget/packages/jetbrains.resharper.globaltools/2026.1.1/tools/net8.0/any/cleanupcode.exe Terminal.Gui.Editor.slnx --profile=TG.Editor Full Cleanup (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI assigned Copilot and tig May 22, 2026
Copilot AI linked an issue May 22, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Fix release workflow failure for v2.2.1-develop.163 Fix release build break in ted caused by malformed conditional and missing System.Text import May 22, 2026
Copilot finished work on behalf of tig May 22, 2026 02:57
Copilot AI requested a review from tig May 22, 2026 02:57
Copy link
Copy Markdown
Collaborator

@BDisp BDisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be merged quickly.

@tig tig marked this pull request as ready for review May 22, 2026 13:26
@tig tig merged commit 1183b37 into develop May 22, 2026
8 checks passed
@tig tig deleted the copilot/fix-release-v2-2-1-develop-163 branch May 22, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release v2.2.1-develop.163 failed

3 participants