refactor!: move all namespaces under Terminal.Gui.Editor#232
Merged
Conversation
BREAKING CHANGE: All namespaces in the Editor assembly are now rooted under Terminal.Gui.Editor.*: - Terminal.Gui.Document -> Terminal.Gui.Editor.Document - Terminal.Gui.Document.Folding -> Terminal.Gui.Editor.Document.Folding - Terminal.Gui.Document.Search -> Terminal.Gui.Editor.Document.Search - Terminal.Gui.Document.Utils -> Terminal.Gui.Editor.Document.Utils - Terminal.Gui.Highlighting -> Terminal.Gui.Editor.Highlighting - Terminal.Gui.Highlighting.Xshd -> Terminal.Gui.Editor.Highlighting.Xshd - Terminal.Gui.Text.Indentation -> Terminal.Gui.Editor.Indentation Consumers must update using directives when upgrading. Closes #231 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1560566 to
3402bea
Compare
ReSharper sorts Terminal.Gui.Editor.* after Terminal.Gui.Drawing/Input alphabetically, which changed relative positions after the rename. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
3402bea to
3682df0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves all namespaces in the Editor assembly under the
Terminal.Gui.Editor.*root, per #231.BREAKING CHANGE
All namespaces are now consistently rooted under
Terminal.Gui.Editor:Terminal.Gui.DocumentTerminal.Gui.Editor.DocumentTerminal.Gui.Document.FoldingTerminal.Gui.Editor.Document.FoldingTerminal.Gui.Document.SearchTerminal.Gui.Editor.Document.SearchTerminal.Gui.Document.UtilsTerminal.Gui.Editor.Document.UtilsTerminal.Gui.HighlightingTerminal.Gui.Editor.HighlightingTerminal.Gui.Highlighting.XshdTerminal.Gui.Editor.Highlighting.XshdTerminal.Gui.Text.IndentationTerminal.Gui.Editor.IndentationNamespaces that were already correct (
Terminal.Gui.Editor,Terminal.Gui.Editor.Completion,Terminal.Gui.Editor.Rendering) are unchanged.Migration
Consumers need to update their
usingdirectives:Verification
dotnet format --verify-no-changespassesCloses #231