Skip to content

Move Editor namespace from Terminal.Gui.Views to Terminal.Gui.Editor#98

Closed
Copilot wants to merge 2 commits into
developfrom
copilot/fix-editor-namespace-issue
Closed

Move Editor namespace from Terminal.Gui.Views to Terminal.Gui.Editor#98
Copilot wants to merge 2 commits into
developfrom
copilot/fix-editor-namespace-issue

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 13, 2026

The Editor class and its rendering types were in Terminal.Gui.Views, inconsistent with the assembly name Terminal.Gui.Editor. Namespace now matches assembly.

Changes

  • <RootNamespace> in .csproj: Terminal.Gui.ViewsTerminal.Gui.Editor
  • Editor.*.cs, Gutter.cs: namespace Terminal.Gui.Viewsnamespace Terminal.Gui.Editor
  • Rendering/*.cs: namespace Terminal.Gui.Views.Renderingnamespace Terminal.Gui.Editor.Rendering
  • Embedded resource prefix in Resources.cs: updated to Terminal.Gui.Editor.Highlighting.Resources. so .xshd files resolve correctly at runtime
  • All consumers (tests, examples, benchmarks): using Terminal.Gui.Viewsusing Terminal.Gui.Editor where the import was for our Editor type; using Terminal.Gui.Views retained where TG's own Window, Dialog, CheckState, etc. are still needed
  • Docs (README.md, CLAUDE.md, specs/): updated namespace references

Before / After

// Before
using Terminal.Gui.Views;
using Terminal.Gui.Views.Rendering;

// After
using Terminal.Gui.Editor;
using Terminal.Gui.Editor.Rendering;

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • www.jetbrains.com
    • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/.nuget/packages/jetbrains.resharper.globaltools/2026.1.1/tools/net8.0/any/cleanupcode.unix.runtimeconfig.json /home/REDACTED/.nuget/packages/jetbrains.resharper.globaltools/2026.1.1/tools/net8.0/any/cleanupcode.exe Terminal.Gui.Editor.slnx --profile=TG.Editor Full Cleanup --no-build --exclude=third_party/**/* s.cs nfig/composer/ves/Views\.Editor/Editor/g sed -i Editor/g layedEvents.cs k/_temp/ghcca-node/node/bin/sed i.Editor;/ rReadOnlyTests.c-i /opt/pipx_bin/ses/Views\.Editor/Editor/g sed (dns block)
    • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/.nuget/packages/jetbrains.resharper.globaltools/2026.1.1/tools/net8.0/any/cleanupcode.unix.runtimeconfig.json /home/REDACTED/.nuget/packages/jetbrains.resharper.globaltools/2026.1.1/tools/net8.0/any/cleanupcode.exe Terminal.Gui.Editor.slnx --profile=Built-in: Full Cleanup --no-build --exclude=third_party/**/* rSelectionTests.-i /snap/bin/sed sed -i Editor/g mpressingTreeList.cs ndor/bin/sed i.Editor;/ ebug/net10.0/Ter-a ndor/bin/sed sed (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI assigned Copilot and tig May 13, 2026
Copilot AI linked an issue May 13, 2026 that may be closed by this pull request
- Update <RootNamespace> in .csproj from Terminal.Gui.Views to Terminal.Gui.Editor
- Change namespace Terminal.Gui.Views -> Terminal.Gui.Editor in all Editor.*.cs and Gutter.cs files
- Change namespace Terminal.Gui.Views.Rendering -> Terminal.Gui.Editor.Rendering in all Rendering/ files
- Update using directives in all tests, examples, and benchmarks
- Fix embedded resource prefix in Resources.cs to match new namespace
- Restore Terminal.Gui.Views using in files that need TG's own Window/Dialog/etc types
- Update documentation in README.md, CLAUDE.md, and specs/ files

Agent-Logs-Url: https://github.com/gui-cs/Editor/sessions/ef20df44-fad9-4ce4-a546-ddbd5b72dc8e

Co-authored-by: tig <585482+tig@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix Editor namespace to match assembly Terminal.Gui.Editor Move Editor namespace from Terminal.Gui.Views to Terminal.Gui.Editor May 13, 2026
Copilot finished work on behalf of tig May 13, 2026 06:54
Copilot AI requested a review from tig May 13, 2026 06:54
@tig tig marked this pull request as ready for review May 13, 2026 07:13
@tig tig closed this May 13, 2026
tig added a commit that referenced this pull request May 13, 2026
…itor

Align the namespace with the assembly name. This is the same change as PR #98
(copilot/fix-editor-namespace-issue) applied directly to the folding-ui branch.

- Changed RootNamespace in .csproj from Terminal.Gui.Views to Terminal.Gui.Editor
- Updated all namespace declarations (Terminal.Gui.Views -> Terminal.Gui.Editor,
  Terminal.Gui.Views.Rendering -> Terminal.Gui.Editor.Rendering)
- Updated embedded resource prefix in Resources.cs
- Updated using directives across tests, examples, and benchmarks
- Re-added 'using Terminal.Gui.Views' where TG's own view types are needed
- Updated specs/docs references

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should Editor be in Terminal.Gui.Views namespace?

2 participants