Open
Conversation
Member
Author
|
CI note: macOS and Windows passed on run 25613380302. Ubuntu fails in the ReSharper cleanupcode step before tests with I checked current develop run 25613103283 and it fails the same way, so I’m treating this as an existing workflow/tooling issue. Per the task constraints I did not edit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #37 and #43.
This chooses option (b) from the experiment prompt: implement the VisualLineBuilder slice needed for D1, then implement tab handling on top of it. This is not the full B1/B2 pipeline; cache invalidation, folding markers, and line-number background migration remain out of scope and are called out in the final run report.
Changes:
Validation
Note: dotnet tool restore succeeded. dotnet jb cleanupcode Terminal.Gui.Text.slnx --profile="Full Cleanup" failed because the JetBrains CLI did not recognize the solution cleanup profile in this .slnx checkout; cleanup against the touched projects ran with the built-in reformat profile.