Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 30 minutes and 27 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts the release GitHub Actions workflow to always run tests/plugin checks, prevent re-triggering the workflow from the bot’s version-bump commit, and handle existing tags safely while updating the release action version. Sequence diagram for updated release job tag handling and [skip ci] commitsequenceDiagram
participant WF as Workflow_release
participant Version as Job_version
participant Release as Job_release
participant Git as GitHub_repo_origin
participant GHRel as GitHub_Releases_API
WF->>Version: Compute semVer with GitVersion
Version-->>WF: semVer output
WF->>Release: Start release job with semVer
Release->>Release: Update ipquery.php and readme.txt with semVer
Release->>Release: git add version files
Release->>Release: git diff --cached --quiet
alt Version files changed
Release->>Git: git commit -m "chore: bump version to semVer [skip ci]"
else No changes
Release->>Release: Skip commit
end
Release->>Git: git ls-remote --tags origin
alt Tag vSemVer already exists
Release->>Git: git push origin main
else Tag vSemVer does not exist
Release->>Git: git tag vSemVer
Release->>Git: git push origin main vSemVer
end
Release->>Release: Build release ZIP
Release->>GHRel: Create GitHub Release using tag vSemVer (softprops/action-gh-release@v2)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The remote tag existence check in the release job has a race window between
git ls-remoteandgit tag/git push; if concurrent workflows run, consider using an atomic push (e.g.git push --atomic origin main v${VERSION}) or a server-side protection to avoid duplicate/rejected tags. - The new inline tag-existence logic in the
releasejob duplicates the earlier (now removed) tag check behavior inversion; if you expect to evolve this further, consider centralizing the tag-existence check in a single step/job to keep the workflow logic easier to reason about.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The remote tag existence check in the release job has a race window between `git ls-remote` and `git tag`/`git push`; if concurrent workflows run, consider using an atomic push (e.g. `git push --atomic origin main v${VERSION}`) or a server-side protection to avoid duplicate/rejected tags.
- The new inline tag-existence logic in the `release` job duplicates the earlier (now removed) tag check behavior in `version`; if you expect to evolve this further, consider centralizing the tag-existence check in a single step/job to keep the workflow logic easier to reason about.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
🔍 WordPress Plugin Check Report
📊 Report
|
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
18 |
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound | Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$total_visits". |
19 |
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound | Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$unique_ips". |
20 |
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound | Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$risk_counts". |
21 |
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound | Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$top_countries". |
22 |
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound | Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$top_cities". |
52 |
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound | Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$risky_pct". |
106 |
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound | Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$row". |
145 |
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound | Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$row". |
173 |
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound | Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$risk_items". |
205 |
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound | Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$item". |
📁 includes/class-ipquery-db.php (2 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
268 |
PluginCheck.Security.DirectDB.UnescapedDBParameter | Unescaped parameter $rows_sql used in $wpdb->get_results()\n$rows_sql assigned unsafely at line 267. |
272 |
PluginCheck.Security.DirectDB.UnescapedDBParameter | Unescaped parameter $count_sql used in $wpdb->get_var()\n$count_sql assigned unsafely at line 271. |
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check
|
Failed to generate code suggestions for PR |
📑 Description
Fix release workflow
✅ Checks
☢️ Does this introduce a breaking change?
Summary by Sourcery
Simplify and harden the release workflow to always run validation jobs while safely handling version tagging and CI triggers.
Build: