Add attribute support to Text tags#53
Merged
Merged
Conversation
Adds support for if-set, if-not-set, if-before, and if-after attributes
philormand
approved these changes
Oct 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for if-set, if-not-set, if-before, and if-after attributes to Text tags. Please note, attributes are only supported on the root
<Text>tag, and not on sub-nodes such as<P>tags etc.Perhaps somewhat obviously, this also means
<Text>nodes can appear more than once in a<Page>now. Text nodes are concatenated in the order they appear, taking into consideration the conditional attributes. An abbreviated constructor needing only the text string was created on theTextmodel to aid in backwards compatibility and creating special pages (like the 404) on the fly.You can use This Test Script (txt extension added to make GitHub happy) to test these new features.
Resolves #9