Conversation
There was a problem hiding this comment.
Pull request overview
Upgrades the build and codebase from Scala 2.x to Scala 3.3.7 LTS, modernizing language features (enums/givens/import syntax) and refreshing sbt/plugins/CI to match the newer toolchain.
Changes:
- Upgrade build to Scala 3.3.7 + sbt 1.12.7; refresh plugins and add BuildHelper settings.
- Migrate core code to Scala 3 syntax (
enum Cell,given/using, wildcard imports) and update tests accordingly. - Replace Travis with GitHub Actions CI/release automation and add dependency update automation (Dependabot + Scala Steward).
Reviewed changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| version.sbt | Removes explicit build version definition. |
| README.md | Removes legacy CI/codecov badges. |
| project/plugins.sbt | Updates sbt plugins for modern Scala/sbt toolchain. |
| project/BuildHelper.scala | Adds shared build settings (Java target, scalac/tpolecat options, no-doc). |
| project/build.properties | Upgrades sbt version. |
| core/src/test/scala/.../ConcurrentConstantMemoryExcelSpec.scala | Migrates tests to ScalaTest 3.2 style + Scala 3 conversions. |
| core/src/main/scala/.../utils/KantanExtension.scala | Ports implicit encoder to Scala 3 given; tweaks array handling. |
| core/src/main/scala/.../ConcurrentConstantMemoryExcel.scala | Scala 3 migration, including Cell as enum and given instances. |
| build.sbt | Reworks build definition for Scala 3 + new publishing/formatting/scalafix setup. |
| .travis.yml | Removes Travis CI config. |
| .scalafmt.conf | Replaces minimal config with Scala 3-aware scalafmt configuration. |
| .scalafix.conf | Adds Scala 3-friendly scalafix rule set. |
| .jvmopts | Adds JVM/SBT runtime options (incl. JDK 25-related flags). |
| .gitignore | Adds .bsp ignore. |
| .github/workflows/scala-steward.yml | Adds scheduled Scala Steward automation. |
| .github/workflows/release.yml | Adds release publishing workflow. |
| .github/workflows/draft.yml | Adds Release Drafter workflow. |
| .github/workflows/ci.yaml | Adds CI matrix for Java 17/21/25 + formatting job. |
| .github/release-drafter.yml | Adds release drafter configuration. |
| .github/dependabot.yml | Adds Dependabot updates for GitHub Actions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| timeout-minutes: 45 | ||
| runs-on: ubuntu-latest | ||
| name: Scala Steward | ||
| steps: |
- Change scalaVersion from 2.13.18 to 3.3.7 - Rewrite Cell as a Scala 3 enum - Replace implicit vals/defs with given instances - Replace implicit conversions with given Conversion - Update wildcard imports from _ to * syntax - Replace deprecated private[this] with private - Remove @nowarn annotations on case classes (no longer needed in Scala 3) - Add @unchecked to irrefutable pattern match - Remove Scala 3-incompatible scalafix rules (RemoveUnused, LeakingImplicitClassVal, NoAutoTupling) - Remove semanticdbVersion override (built-in in Scala 3)
disable-releaser on PR events to prevent invalid target_commitish error. Also fix branch name from main to master.
Remove pull_request trigger that caused invalid target_commitish errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cellas a Scala 3enumimplicitvals/defs withgiveninstances andusingclausesgiven Conversion[A, B]*), remove deprecatedprivate[this]RemoveUnused,LeakingImplicitClassVal,NoAutoTupling)Test plan
sbt compilepassessbt test)scalafmtCheckpasses