Update devDependencies. #141
Conversation
package.json
Outdated
| "lint": "eslint . && jscs index.js bin/ lib/ test/", | ||
| "prepublish": "marked-man --name gulp docs/CLI.md > gulp.1", | ||
| "prepare": "marked-man --name gulp docs/CLI.md > gulp.1", | ||
| "prepublishOnly": "npm run prepare", |
There was a problem hiding this comment.
I still use npm@2 so this won't work for me.
There was a problem hiding this comment.
Sorry. prepare and prepublishOnly was introduced in npm@4. I'll put back this.
.gitignore
Outdated
| test/output/ | ||
| test/watch-*.txt | ||
| gulp.1 | ||
| package-lock.json |
There was a problem hiding this comment.
Makes sense but does npm pick up .npmrc files from the repo? Might be better to include an npmrc that stops the package-lock creation. Also, belongs in a separate commit.
There was a problem hiding this comment.
I got it. I'll commit .npmrc separately.
| "eslint-config-gulp": "^2.1.0", | ||
| "expect": "^1.20.2", | ||
| "gulp": "gulpjs/gulp#4.0", | ||
| "gulp": "^4.0.0", |
There was a problem hiding this comment.
I think we should only update this in the dep update PR.
| } | ||
| ] | ||
| } | ||
| { |
There was a problem hiding this comment.
These files were causing problems on my machine due to weird line ending stuff. I had to tell git to ignore the changes to make them go away.
|
@phated I've removed unnecessary modifications and have separated into commits of updating dev dependencies and disabling package-lock.json. |
| "gulp": "^4.0.0", | ||
| "gulp-test-tools": "^0.6.1", | ||
| "jscs": "^2.3.5", | ||
| "jscs": "^3.0.7", |
There was a problem hiding this comment.
I thought jscs changed a bunch of stuff in 3.0 that made our config file invalid?
There was a problem hiding this comment.
Release note of jscs 3.0 wrote:
We didn't rename/remove any rules. ...
So I think there are no problem to use 3.0.
| "jscs": "^3.0.7", | ||
| "jscs-preset-gulp": "^1.0.0", | ||
| "marked-man": "^0.1.3", | ||
| "marked-man": "^0.2.1", |
There was a problem hiding this comment.
Just I think newer module is better. Doesn't ^0.1.3 represents the range >=0.1.3 <0.2.0?
|
I've update more dependency versions, fancy-log and so on. |
|
@sttk I cherry-picked your commits into master and squashed some stuff (needed to deal with line endings of those fixtures on my new computer) - I'll get this published with the exitCode thing. |
|
@phated I got it. Thanks! |
2 participants
I've updated devDependencies in package.json and have made tests succeed.