Skip to content

Conversation

@kayo5994
Copy link

Fix for gulpjs/gulp#2098.

@phated
Copy link
Member

phated commented Jan 17, 2018

The semver range we've specified in the package.json already accounts for the version range you are trying change. It's likely that your problem is a package-lock.json file and not the way we specify dependency ranges.

@phated phated closed this Jan 17, 2018
@demurgos
Copy link
Member

demurgos commented Jan 17, 2018

Shouldn't the semver range be updated anyway?
If this library does not work properly unless the version of fancy-log is at least 1.3.0 then it should state so in the package file.

I also think that in a proper environment, a fresh install should be fine but you can always imagine a way for it to break if you just rely on the specifics of the resolution algorithm of one of the package managers.
Assume that I have a dependency on a plugin with an exact dependency on fancy-log@1.2.0, with npm's installation algorithm it may install this version first and then when it reaches gulp-cli it will not install the latest version but reuse the older one (and exhibit the issue, even without a lock file).

@phated
Copy link
Member

phated commented Jan 17, 2018

Assume that I have a dependency on a plugin with an exact dependency on fancy-log@1.2.0, with npm's installation algorithm it may install this version first and then when it reaches gulp-cli it will not install the latest version but reuse the older one

Yeah, I guess npm does that now with their automatic deduping algorithm. This is why I should have never upgrade from node 0.10/npm 2 😛

I'll have @sttk bump the minor versions for deps in #141 since it all falls under "Upgrade".

@phated phated mentioned this pull request Jan 17, 2018
@phated
Copy link
Member

phated commented Jan 22, 2018

Published as 2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants