Skip to content

Switching to jscs-preset-gulp preset#44

Merged
phated merged 1 commit intogulpjs:masterfrom
pdehaan:jscs-preset
Oct 22, 2015
Merged

Switching to jscs-preset-gulp preset#44
phated merged 1 commit intogulpjs:masterfrom
pdehaan:jscs-preset

Conversation

@pdehaan
Copy link
Copy Markdown
Contributor

@pdehaan pdehaan commented Oct 22, 2015

$ npm run lint

> gulp-cli@0.3.0 lint /Users/pdehaan/dev/github/gulp-cli
> jshint lib index.js --reporter node_modules/jshint-stylish --exclude node_modules && jscs index.js lib bin test


✔ No problems

$ echo $?
0

phated added a commit that referenced this pull request Oct 22, 2015
Switching to jscs-preset-gulp preset
@phated phated merged commit 702f59c into gulpjs:master Oct 22, 2015
@Romanx
Copy link
Copy Markdown
Contributor

Romanx commented Oct 27, 2015

Not to bump a dead commit but shouldn't this also be in the 4.0 branch?

@phated
Copy link
Copy Markdown
Member

phated commented Oct 27, 2015

I'll be rebasing it later

@Romanx
Copy link
Copy Markdown
Contributor

Romanx commented Nov 2, 2015

@phated still hasn't seem to have happened? Just wondering for my pr :)

@phated
Copy link
Copy Markdown
Member

phated commented Nov 2, 2015

@Romanx oh, I meant after your PR was merged. Was waiting on a way to test different gulp versions.

@Romanx
Copy link
Copy Markdown
Contributor

Romanx commented Nov 2, 2015

no problem, my mistake!

phated added a commit that referenced this pull request Dec 21, 2017
Switching to jscs-preset-gulp preset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants