This repository was archived by the owner on Sep 1, 2022. It is now read-only.
Fixed buffer bug from through2 upgrade #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Wow this one slipped through the cracks - what's wrong with the existing test that it passed with this being so broken? |
yocontra
added a commit
that referenced
this pull request
Jan 27, 2014
Fixed buffer bug from through2 upgrade
Contributor
Author
|
The existing test just checked for a I'm kinda needing this for a project. Think you can push out an NPM version bump? Thanks! |
Member
|
2.2.13 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emitting
datawiththrough2doesn't actually pass the data to the next stream. You have topushit since these areSteams2. This fix passes the buffered data in the next stream. The test I added would've passed before thethroughtothrough2upgrade.