This repository was archived by the owner on Sep 1, 2022. It is now read-only.
Fix hard-coded path separator in assertion string #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Whoa - I totally overlooked this. My tests for vinyl, vinyl-fs, etc. must all be failing on windows as well |
yocontra
added a commit
that referenced
this pull request
Jun 4, 2014
Fix hard-coded path separator in assertion string
Member
|
Wouldn't path.resolve or path.normalize work for this as well? |
Contributor
Author
Haven't tried running tests for vinyl & friends locally yet.
I like |
Member
|
Another PR then? |
Contributor
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a test that was failing on Windows because of hard-coded path separator in assertion string.