Update "through2" and "minimist" to match the current version #52
Conversation
package.json
Outdated
There was a problem hiding this comment.
don't bump versions in other peoples repos ;)
There was a problem hiding this comment.
Removed module version increment.
Update "through2" and "minimist" to match the current version
|
Would you guys mind pushing a new version to npm to reflect this changes? Thanks! |
|
@tomchentw We'll bump when there's something worth bumping for. Please stop spamming repos with bumping through2. It's totally meaningless. Thanks :) |
|
Published as 2.2.18 |
|
Sorry about the PRs and if I making any inconvenience for you. |
|
@tomchentw I like it |
|
@tomchentw didn't mean to be harsh, no worries, but I get too many of these PRs a week. There will always be some duplication. New versions are released all the time. It would be a fulltime job to just bump versions if I were to upgrade every time. Right now there's two versions of through2 in gulp plugins. Having that be one instead has absolutely no impact on anything. There's a lot worse problems, like packages leaving huge fixtures of many megabytes in the package. I would rather target fixing that. |
|
@sindresorhus 0.5 had a change to the highWaterMark (16000 -> 16, so backpressure happens more often) and some perf updates so IMO it's worthy to update the versions and patch bump |
|
@contra Well the PR didn't say that. But that's still pretty useless as most gulp plugins are just object streams with buffers. |
|
@sindresorhus It went from 16000 objects to 16 objects, so this will help with the bug where the process ran out of memory because gulp.src spit 10K files into memory before the pipeline could start processing them |
|
@contra Valid point. If that were the PR description I would have happily accepted. |
|
@sindresorhus I really appreciate your guys help to maintain the gulp eco-system. If there's anything I can help with, please let me know :) I would really love to make the gulp eco-system more healthy. The reason I'm bumping these plugins is that I'm working on a library that would heavily depend on It would be great if you and @contra could take a loot at it and we can discuss here (Sorry for the bad naming :P ). |
|
@tomchentw we could always need help improving the docs, ensuring community plugins are high-quality, blacklisting non-conforming plugins, finding community painpoints with gulp and ways to improve it, triaging issues, etc. We're thankful for whatever you'll contribute with :) |
... except version bump pull requests 😜 |
Give me a good reason to merge and I will. Deduplicating two versions is not ;) |
|
@tomchentw re your sprockets thingy. Here's some naming suggestions: http://thesaurus.com/browse/sprockets I would seriously reconsider coding it in LiveScript if you're looking to get active contributors (not impossible, but a lot harder). The intro example could also be clearer. I don't see the immediate benefit. |
It is to me (and to other people as well, seems like). Part of the problem IMHO is that a lot of plugins are still on |
|
@milang tricky part is |
It's really cool. Thanks @sindresorhus !
I totally agree. But maybe until it got enough traction?
I've put my incentive here. Simply put, it let you focus on development instead of configuration every time. (To not disturb all of you guys in the thread, we can discuss this in sprocket issue page. ) |
That's kinda contradictory because it might limit your traction. Some people don't like using things when they can't be able to improve on it themselves.
That should be at the top and much clearer:
That's not saying much when you don't know what sprockets in Ruby is. |
|
@tomchentw Once 0.12 drops as stable we can switch to streams3, it's non-breaking with streams2 so it should be fine. It provides some extra compat for streams1 which would be nice to have in gulp core |
4 participants
Helps when deduping projects using
gulp-util.