Skip to content

Create Responsify-Images.md#1778

Closed
retrocausal wants to merge 2 commits intogulpjs:masterfrom
retrocausal:master
Closed

Create Responsify-Images.md#1778
retrocausal wants to merge 2 commits intogulpjs:masterfrom
retrocausal:master

Conversation

@retrocausal
Copy link
Copy Markdown

Add a recipe to illustrate generation and minification of images for the web

Add a recipe to illustrate generation and minification of images for the web
Copy link
Copy Markdown

@QWp6t QWp6t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has completely different code and editorial styles from all of the rest of the recipes. The editorial style differences are obvious. The code differences include using $ instead of gulp as well as the use of gulp-load-plugins, plus the abundance of code comments, and a few other minor differences.

I personally think it's easier for people new to gulp to see the recipes presented as consistently as possible, but on the other hand, the argument could be made that the "recipes" should reflect the editorial and code styles of the "chef" who writes them (again, I don't find this reasoning to be compelling enough, but I do recognize it has some merit).

Aligning syntax to maintain consistency. See PR  #1778.
Removing gulp-load-plugins and requiring individuals
Reduce Documentation where necessary
@retrocausal
Copy link
Copy Markdown
Author

@QWp6t

Agreed. Syntactically, the code in a recipe must align with its predecessors. made subtle changes here and there, but took care of dropping gulp-load-plugins, and replaced $ to gulp
Also replaced $$(previously aliasing gulp-load-plugins) to actual variable names as in their require declaration

@phated
Copy link
Copy Markdown
Member

phated commented Jun 22, 2018

We are currently rewriting all the docs so I'm going to close this.

@phated phated closed this Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants