Document the new gulp.task API. by dinoboff · Pull Request #937 · gulpjs/gulp

dinoboff · 2015-03-01T00:27:17Z

Also add the gulp.series and gulp.parallel APIs.
#803, #841 and #925

heikki · 2015-03-01T00:35:20Z

docs/API.md

gulp.series

heikki · 2015-03-01T00:41:09Z

docs/API.md

Is this note still valid?

You're right. It's not relevant in the gulp.task documentation

phated · 2015-03-01T00:49:20Z

docs/API.md

should link to undertaker

It is; it's a link and its URL is defined at the end of the file.

phated · 2015-03-01T01:00:30Z

docs/recipes/running-tasks-in-series.md

and RxJS observable

phated · 2015-03-01T01:02:50Z

@dinoboff you are amazing. thanks for all the hard work

yocontra · 2015-03-01T01:04:23Z

docs/API.md

should note that named functions will have a .name attribute

I am changing the note to:

`Function.name` is not writable; it cannot be set or edited. It will be empty for anonymous function:

dinoboff · 2015-03-01T01:33:25Z

docs/API.md

@phated is it ok?

phated · 2015-03-04T18:05:41Z

I'm hoping to review the vinyl-fs docs and other changes Friday night or this weekend.

phated · 2015-03-13T19:40:00Z

docs/API.md

is this a string? or is it an actual Octal? "0777" vs 0777

Tested, and both work.

@phated Should I reword it to:

options.mode

Type: String or Number

Default: the mode of the input file (file.stat.mode) or the process mode if the input file has no mode property.

Octal permission specifying the mode the files should be created with: e.g. "0777", 0777 or 511 (0777 in base 10).

yeah, i think that would be more clear

phated · 2015-03-13T22:04:11Z

After my comments are addressed, I am 👍 on this

Also add the gulp.series and gulp.parallel APIs

dinoboff · 2015-03-13T23:06:55Z

@contra can you review and merge it please?

phated · 2015-03-14T02:35:39Z

docs/recipes/using-external-config-file.md

just checked the amount of downloads on each. I'm going to switch it back to merge-stream

phated · 2015-03-14T02:39:42Z

merged

ashwell · 2015-04-01T20:32:45Z

I have been playing with gulp 4.0, works great for me. In looking at the docs, a function gulp.symlink has been documented but apparently not implemented as it is undefined on the gulp instance. Looking at index.html it would seem that below line number 13 this line should be added:

Gulp.prototype.symlink = vfs.symlink;

no?

phated · 2015-04-01T21:23:42Z

@ashwell good catch, just pushed the addition.

ashwell · 2015-04-01T21:27:49Z

YAY! I helped!

heikki reviewed Mar 1, 2015
View reviewed changes

docs/API.md Outdated

Copy link

Contributor

heikki Mar 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gulp.series

dinoboff force-pushed the dinoboff-undertaker-doc branch from 09fd1d7 to 798ca30 Compare March 1, 2015 00:38

heikki reviewed Mar 1, 2015
View reviewed changes

dinoboff force-pushed the dinoboff-undertaker-doc branch 2 times, most recently from 0918748 to 151b956 Compare March 1, 2015 00:48

phated reviewed Mar 1, 2015
View reviewed changes

dinoboff force-pushed the dinoboff-undertaker-doc branch from 151b956 to 932dcef Compare March 1, 2015 00:57

phated reviewed Mar 1, 2015
View reviewed changes

docs/recipes/running-tasks-in-series.md Outdated

Copy link

Member

phated Mar 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and RxJS observable

yocontra reviewed Mar 1, 2015
View reviewed changes

dinoboff force-pushed the dinoboff-undertaker-doc branch 3 times, most recently from 5e66469 to 46392ce Compare March 1, 2015 01:30

dinoboff reviewed Mar 1, 2015
View reviewed changes

docs/API.md Outdated

Copy link

Contributor Author

dinoboff Mar 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phated is it ok?

dinoboff force-pushed the dinoboff-undertaker-doc branch 3 times, most recently from dfea21d to aaca18e Compare March 1, 2015 02:07

dinoboff force-pushed the dinoboff-undertaker-doc branch 7 times, most recently from da9abc3 to 1f5a825 Compare March 2, 2015 16:07

dinoboff mentioned this pull request Mar 2, 2015

Document incremental builds #841

Closed

dinoboff force-pushed the dinoboff-undertaker-doc branch 2 times, most recently from 18985c5 to eba43ad Compare March 4, 2015 02:29

phated reviewed Mar 13, 2015
View reviewed changes

Document the new gulp.task API & vinyl-fs options

8d73425

Also add the gulp.series and gulp.parallel APIs

dinoboff force-pushed the dinoboff-undertaker-doc branch from eba43ad to 8d73425 Compare March 13, 2015 22:06

phated reviewed Mar 14, 2015
View reviewed changes

docs/recipes/using-external-config-file.md

Copy link

Member

phated Mar 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just checked the amount of downloads on each. I'm going to switch it back to merge-stream

phated merged commit 8d73425 into gulpjs:4.0 Mar 14, 2015

dinoboff deleted the dinoboff-undertaker-doc branch March 14, 2015 08:39

Uh oh!

Conversation

dinoboff commented Mar 1, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

phated commented Mar 1, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

phated commented Mar 4, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

options.mode

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

phated commented Mar 13, 2015

Uh oh!

dinoboff commented Mar 13, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

phated commented Mar 14, 2015

Uh oh!

ashwell commented Apr 1, 2015

Uh oh!

phated commented Apr 1, 2015

Uh oh!

ashwell commented Apr 1, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants