Add image filters

[mikestreety]

No description provided.

[mikestreety]

As mention in this issue I've added grayscale and other image filters

[adityapatadia]

Checks are failing. Can you look what is wrong? Please also write unit test for new functions.

[mikestreety]

Apologies - was using PHP7 at home.

I'm not quite sure where to begin with the tests. Would I create images in the ressources and compare them?

[adityapatadia]

check here: https://github.com/eventviva/php-image-resize/tree/master/test

[adityapatadia]

Hi, Any update on this? Will you correct it?

[mikestreety]

No, sorry. I had a look and don't understand what I need to do.

…

On Sun, 3 Sep 2017 at 8:28 pm, Aditya Patadia ***@***.***> wrote: Hi, Any update on this? Will you correct it? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#90 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVnJQmUha3aBiqWF8G0GGpInviQrSy1ks5sev3GgaJpZM4O1twb> .

[adityapatadia]

Please check link for unit tests already written. You would ideally add one pre-processed image as string and then compare it with one unprocessed image processed by this library. This file has all tests written: https://github.com/eventviva/php-image-resize/blob/master/test/Test.php

[rakshazi]

Hi!
Any update on this?

[adityapatadia]

It's pending because if unit tests.

[mikestreety]

Hello,

Sorry, I've not looked further into this - been slammed with work and personal projects.

I'm not quite sure how to make a pre-processed image as a string and still unsure how to write the tests for this. Any help would be hugely appreciated.

[adityapatadia]

You can use fromstring and tostring methods of this library. Please check readme file and also check the test source code which can be found from above link I posted.

[mikestreety]

Hey, sorry for the delayed reply. I've tried and failed many times to pick this up and understand it but my brain just won't accept it.

If this is not a viable pull request - delete it and I'll use my own fork on my personal projects. Sorry to be a burden!

Thanks for the great package 😄

[nanmu42]

Thanks for the effort anyway, dude. 👍