Skip to content

Refactoring image tools#26

Merged
Jan-Loettgen merged 42 commits intomainfrom
refactoring-image-tools
Jun 2, 2023
Merged

Refactoring image tools#26
Jan-Loettgen merged 42 commits intomainfrom
refactoring-image-tools

Conversation

@Sajtospoga01
Copy link
Copy Markdown
Contributor

Changes some documentation format, in image tools, changes the directory structure, adds tests for image tools

Sajtospoga01 and others added 21 commits March 19, 2023 13:57
fixes pytest coverage run

changes path for code coverage export

update coverage configuration

change coverage report to account for root directory

updates coverage provider to codecov

changes path for coverage report save

enters coverage folder to check content

further debugs github CI

tries printing directory of repo

attempts debug on the pipeline coverage report cant be accessed

adds ability to CI to create coverage directory if it doesn't exist

updates devops pytest coverage to use the correct version
…l where it could pad images if it was exact size
@Sajtospoga01 Sajtospoga01 self-assigned this Mar 26, 2023
@Sajtospoga01 Sajtospoga01 temporarily deployed to development March 26, 2023 17:27 — with GitHub Actions Inactive
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@ee03281). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage        ?   84.25%           
=======================================
  Files           ?        6           
  Lines           ?      508           
  Branches        ?        0           
=======================================
  Hits            ?      428           
  Misses          ?       80           
  Partials        ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Sajtospoga01 Sajtospoga01 temporarily deployed to development March 26, 2023 18:06 — with GitHub Actions Inactive
@Sajtospoga01 Sajtospoga01 temporarily deployed to development March 26, 2023 18:15 — with GitHub Actions Inactive
@Sajtospoga01 Sajtospoga01 temporarily deployed to development April 3, 2023 18:50 — with GitHub Actions Inactive
@Sajtospoga01 Sajtospoga01 temporarily deployed to development April 16, 2023 11:27 — with GitHub Actions Inactive
… to check segmentation mask class distribution in specific directory
@Sajtospoga01 Sajtospoga01 temporarily deployed to development May 6, 2023 17:20 — with GitHub Actions Inactive
@Sajtospoga01 Sajtospoga01 temporarily deployed to development May 9, 2023 17:48 — with GitHub Actions Inactive
@Sajtospoga01 Sajtospoga01 temporarily deployed to development May 16, 2023 11:40 — with GitHub Actions Inactive
@Sajtospoga01 Sajtospoga01 temporarily deployed to development May 19, 2023 19:41 — with GitHub Actions Inactive
@Sajtospoga01 Sajtospoga01 temporarily deployed to development May 19, 2023 20:18 — with GitHub Actions Inactive
---------
:NDArray[Any] image: Numpy array representing image to cut [H,W,C].
:tuple[int, int] cut_dims: desired dimensions to cut images to.
:int, optional num_bands: Number of bands of input image. Defaults to 1.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really the number of bands in the input images should not a function argument instead check the images to be cut

print("the following files are located at input Path :")
dir_contents = os.listdir(path_ims)
dir_contents = sorted(dir_contents)
batch_size = 100
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be a function argument

Copy link
Copy Markdown
Contributor

@Jan-Loettgen Jan-Loettgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jan-Loettgen Jan-Loettgen merged commit c1a8e32 into main Jun 2, 2023
@Jan-Loettgen Jan-Loettgen deleted the refactoring-image-tools branch June 2, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants