Skip to content

Reader reimplementation#40

Merged
AyleenSohaib merged 18 commits intomainfrom
reader_reimplementation
Jul 30, 2023
Merged

Reader reimplementation#40
AyleenSohaib merged 18 commits intomainfrom
reader_reimplementation

Conversation

@Sajtospoga01
Copy link
Copy Markdown
Contributor

No description provided.

@Sajtospoga01 Sajtospoga01 temporarily deployed to development June 26, 2023 09:07 — with GitHub Actions Inactive
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 26, 2023

Codecov Report

Merging #40 (f3c59f2) into main (c1a8e32) will decrease coverage by 10.45%.
The diff coverage is 64.93%.

@@             Coverage Diff             @@
##             main      #40       +/-   ##
===========================================
- Coverage   84.25%   73.80%   -10.45%     
===========================================
  Files           6        7        +1     
  Lines         508      710      +202     
===========================================
+ Hits          428      524       +96     
- Misses         80      186      +106     
Files Changed Coverage Δ
utilities/transform_utils/image_cutting.py 60.24% <0.00%> (-0.25%) ⬇️
utilities/segmentation_utils/flowreader.py 59.16% <52.17%> (-22.66%) ⬇️
utilities/segmentation_utils/ImagePreprocessor.py 75.80% <53.33%> (-24.20%) ⬇️
...ts/segmentation_utils_tests.py/flow_reader_test.py 85.41% <100.00%> (-11.43%) ⬇️
...entation_utils_tests.py/image_preprocessor_test.py 80.95% <100.00%> (-19.05%) ⬇️
...sts/segmentation_utils_tests.py/test_flowreader.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Sajtospoga01 Sajtospoga01 temporarily deployed to development June 26, 2023 09:23 — with GitHub Actions Inactive
@Sajtospoga01 Sajtospoga01 self-assigned this Jul 26, 2023
@Sajtospoga01 Sajtospoga01 added enhancement New feature or request backend anything that is associated with the libraries backend API Anything that is associated with the libraries public interface labels Jul 26, 2023
@AyleenSohaib AyleenSohaib temporarily deployed to development July 30, 2023 16:11 — with GitHub Actions Inactive
Copy link
Copy Markdown
Collaborator

@AyleenSohaib AyleenSohaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the issue in the len function so that datasize calculation is done using the mini batch size and not the reader's batch size.

# required to check when to read the next batch

def __len__(self) -> int:
return int(np.floor(len(self.image_filenames) / float(self.mini_batch)))
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to self.mini_batch from self.batch_size as the datasize calculation was incorrect

@AyleenSohaib AyleenSohaib merged commit 81c5efc into main Jul 30, 2023
@AyleenSohaib AyleenSohaib deleted the reader_reimplementation branch July 30, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API Anything that is associated with the libraries public interface backend anything that is associated with the libraries backend enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants