Merged
Conversation
…aking the function more flexible, providing a preprocessing queue interface and clipping data after its sent through the preprocessing queue
…e tf reliant implementation to a self maintained
…ader problems in flowreader
Codecov Report
@@ Coverage Diff @@
## main #40 +/- ##
===========================================
- Coverage 84.25% 73.80% -10.45%
===========================================
Files 6 7 +1
Lines 508 710 +202
===========================================
+ Hits 428 524 +96
- Misses 80 186 +106
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AyleenSohaib
approved these changes
Jul 30, 2023
Collaborator
AyleenSohaib
left a comment
There was a problem hiding this comment.
fixed the issue in the len function so that datasize calculation is done using the mini batch size and not the reader's batch size.
| # required to check when to read the next batch | ||
|
|
||
| def __len__(self) -> int: | ||
| return int(np.floor(len(self.image_filenames) / float(self.mini_batch))) |
Collaborator
There was a problem hiding this comment.
changed to self.mini_batch from self.batch_size as the datasize calculation was incorrect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.