Skip to content

Class variables moved to constructor to make them instance variables.#52

Merged
Sajtospoga01 merged 1 commit intomainfrom
flowreader_class_to_inst_var
Aug 1, 2023
Merged

Class variables moved to constructor to make them instance variables.#52
Sajtospoga01 merged 1 commit intomainfrom
flowreader_class_to_inst_var

Conversation

@AyleenSohaib
Copy link
Copy Markdown
Collaborator

The class variables were moved to the constructor so they become instance variables. The class variable 'preprocessing_seed = None' was removed because it already exists in the constructor as 'preprocessing_seed: Optional [int] = None' and been initialised.

@AyleenSohaib AyleenSohaib self-assigned this Jul 31, 2023
Comment thread utilities/segmentation_utils/flowreader.py
@AyleenSohaib AyleenSohaib temporarily deployed to development July 31, 2023 13:37 — with GitHub Actions Inactive
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 31, 2023

Codecov Report

Merging #52 (c54b79a) into main (81c5efc) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   73.80%   73.76%   -0.04%     
==========================================
  Files           7        7              
  Lines         710      709       -1     
==========================================
- Hits          524      523       -1     
  Misses        186      186              
Files Changed Coverage Δ
utilities/segmentation_utils/flowreader.py 58.94% <100.00%> (-0.22%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment thread utilities/segmentation_utils/flowreader.py
Comment thread utilities/segmentation_utils/flowreader.py
Comment thread utilities/segmentation_utils/flowreader.py
Copy link
Copy Markdown
Collaborator Author

@AyleenSohaib AyleenSohaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the mask preprocessing queue variable has been added below the image preprocessing queue variable

@Sajtospoga01 Sajtospoga01 merged commit a755c68 into main Aug 1, 2023
@Sajtospoga01 Sajtospoga01 deleted the flowreader_class_to_inst_var branch August 1, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants